From: Matt Caswell <matt@openssl.org>
Date: Fri, 19 Jan 2018 14:48:45 +0000 (+0000)
Subject: Don't crash on a missing Subject in index.txt
X-Git-Tag: OpenSSL_1_1_1-pre1~170
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=1e05c6d07ff963107286d028f6778d2ccc863a9a;p=oweals%2Fopenssl.git

Don't crash on a missing Subject in index.txt

An index.txt entry which has an empty Subject name field will cause ca
to crash. Therefore check it when we load it to make sure its not empty.

Fixes #5109

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5114)
---

diff --git a/apps/ca.c b/apps/ca.c
index 551d0aa2f8..9b1d9bdaac 100644
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -663,6 +663,10 @@ end_of_options:
                 goto end;
             }
         }
+        if (pp[DB_name][0] == '\0') {
+            BIO_printf(bio_err, "entry %d: bad Subject\n", i + 1);
+            goto end;
+        }
     }
     if (verbose) {
         TXT_DB_write(bio_out, db->db);