From: Axel Lin Date: Wed, 7 Jan 2015 01:54:56 +0000 (+0800) Subject: spi: cadence_qspi: Fix checking return value of fdt_first_subnode() X-Git-Tag: v2015.01~19^2~3 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=1dc7d00f2783991387fe715d61b50fe7b40fd30a;p=oweals%2Fu-boot.git spi: cadence_qspi: Fix checking return value of fdt_first_subnode() fdt_first_subnode() returns -FDT_ERR_NOTFOUND if no subnode found. 0 is supposed to be a valid offset returns from fdt_first_subnode(). Signed-off-by: Axel Lin Reviewed-by: Jagannadha Sutradharudu Teki --- diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c index fa95b19ecd..98ae3b808f 100644 --- a/drivers/spi/cadence_qspi.c +++ b/drivers/spi/cadence_qspi.c @@ -297,7 +297,7 @@ static int cadence_spi_ofdata_to_platdata(struct udevice *bus) /* All other paramters are embedded in the child node */ subnode = fdt_first_subnode(blob, node); - if (!subnode) { + if (subnode < 0) { printf("Error: subnode with SPI flash config missing!\n"); return -ENODEV; }