From: Matt Caswell <matt@openssl.org>
Date: Wed, 27 Apr 2016 13:59:35 +0000 (+0100)
Subject: Fix memory leak in crl2pkcs7 app
X-Git-Tag: OpenSSL_1_1_0-pre6~608
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=1c422164d8343688b8356fcb26f6b7e06921433b;p=oweals%2Fopenssl.git

Fix memory leak in crl2pkcs7 app

The crl2pkcs7 app leaks a stack of OPENSSL_STRINGs in error paths.

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/apps/crl2p7.c b/apps/crl2p7.c
index 73e62702ce..1631258793 100644
--- a/apps/crl2p7.c
+++ b/apps/crl2p7.c
@@ -143,8 +143,6 @@ int crl2pkcs7_main(int argc, char **argv)
             }
         }
 
-    sk_OPENSSL_STRING_free(certflst);
-
     out = bio_open_default(outfile, 'w', outformat);
     if (out == NULL)
         goto end;
@@ -160,6 +158,7 @@ int crl2pkcs7_main(int argc, char **argv)
     }
     ret = 0;
  end:
+    sk_OPENSSL_STRING_free(certflst);
     BIO_free(in);
     BIO_free_all(out);
     PKCS7_free(p7);