From: Dr. Stephen Henson <steve@openssl.org>
Date: Tue, 19 Jun 2001 00:09:20 +0000 (+0000)
Subject: Don't set *pointer if add_lock_callback used.
X-Git-Tag: OpenSSL_0_9_6b~7
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=1b822decb85ae7131e5687255ae59db34b57afaf;p=oweals%2Fopenssl.git

Don't set *pointer if add_lock_callback used.
---

diff --git a/CHANGES b/CHANGES
index 2d5f6b8622..7b324389b8 100644
--- a/CHANGES
+++ b/CHANGES
@@ -4,6 +4,11 @@
 
  Changes between 0.9.6a and 0.9.6b  [XX xxx XXXX]
 
+  *) Don't change *pointer in CRYPTO_add_lock() is add_lock_callback is
+     used: it isn't thread safe and the add_lock_callback should handle
+     that itself.
+     [Paul Rose <Paul.Rose@bridge.com>]
+
   *) Verify that incoming data obeys the block size in
      ssl3_enc (ssl/s3_enc.c) and tls1_enc (ssl/t1_enc.c).
      [Bodo Moeller]
diff --git a/crypto/cryptlib.c b/crypto/cryptlib.c
index c99851810f..fdb416d598 100644
--- a/crypto/cryptlib.c
+++ b/crypto/cryptlib.c
@@ -430,7 +430,6 @@ int CRYPTO_add_lock(int *pointer, int amount, int type, const char *file,
 			CRYPTO_get_lock_name(type),
 			file,line);
 #endif
-		*pointer=ret;
 		}
 	else
 		{