From: Xiaoyin Liu <xiaoyinl@users.noreply.github.com>
Date: Sat, 5 Aug 2017 06:31:04 +0000 (-0400)
Subject: Add missing HTML tag in www_body in s_server.c
X-Git-Tag: OpenSSL_1_1_1-pre1~873
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=1a9f5cf0d58629ab8972f50e937d8ab78bf27b6f;p=oweals%2Fopenssl.git

Add missing HTML tag in www_body in s_server.c

In the generated HTML document, the `<pre>` tag is not closed. This patch also has a trivial code-style improvement, unrelated to the bug fix.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4088)
---

diff --git a/apps/s_server.c b/apps/s_server.c
index 2ff58b67f9..0ee5519f96 100644
--- a/apps/s_server.c
+++ b/apps/s_server.c
@@ -3113,9 +3113,10 @@ static int www_body(int s, int stype, int prot, unsigned char *context)
                 PEM_write_bio_X509(io, peer);
                 X509_free(peer);
                 peer = NULL;
-            } else
+            } else {
                 BIO_puts(io, "no client certificate available\n");
-            BIO_puts(io, "</BODY></HTML>\r\n\r\n");
+            }
+            BIO_puts(io, "</pre></BODY></HTML>\r\n\r\n");
             break;
         } else if ((www == 2 || www == 3)
                    && (strncmp("GET /", buf, 5) == 0)) {