From: Rich Felker <dalias@aerifal.cx>
Date: Thu, 17 Feb 2011 15:28:56 +0000 (-0500)
Subject: daemon should check for failures and return -1
X-Git-Tag: v0.6.0~8
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=19e35c500bd2b5e6146e42705ab9b69c155a2006;p=oweals%2Fmusl.git

daemon should check for failures and return -1
---

diff --git a/src/linux/daemon.c b/src/linux/daemon.c
index 632d1203..3750fc34 100644
--- a/src/linux/daemon.c
+++ b/src/linux/daemon.c
@@ -19,12 +19,15 @@ int daemon(int nochdir, int noclose)
 	default: _exit(0);
 	}
 
-	if (!nochdir) chdir("/");
-	if (!noclose && (fd = open("/dev/null", O_RDWR)) >= 0) {
-		dup2(fd, 0);
-		dup2(fd, 1);
-		dup2(fd, 2);
+	if (!nochdir && chdir("/"))
+		return -1;
+	if (!noclose) {
+		int failed = 0;
+		if ((fd = open("/dev/null", O_RDWR)) < 0) return -1;
+		if (dup2(fd, 0) < 0 || dup2(fd, 1) < 0 || dup2(fd, 2) < 0)
+			failed++;
 		if (fd > 2) close(fd);
+		if (failed) return -1;
 	}
 
 	return 0;