From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Wed, 21 Dec 2016 03:13:23 +0000 (+0100)
Subject: ash: error out if ASH_INTERNAL_GLOB is not selected on uClibc
X-Git-Tag: 1_26_1~17
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=18a7bee73670af792d25dac1835e75eeeef0a08e;p=oweals%2Fbusybox.git

ash: error out if ASH_INTERNAL_GLOB is not selected on uClibc

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---

diff --git a/shell/ash.c b/shell/ash.c
index 8d8cc466b..7d45b2cd2 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -51,6 +51,14 @@
 # define ENABLE_ASH_INTERNAL_GLOB 1
 #endif
 
+#if !ENABLE_ASH_INTERNAL_GLOB && defined(__UCLIBC__)
+# error uClibc glob() is buggy, use ASH_INTERNAL_GLOB.
+# error The bug is: for "$PWD"/<pattern> ash will escape e.g. dashes in "$PWD"
+# error with backslash, even ones which do not need to be: "/a-b" -> "/a\-b"
+# error glob() should unbackslash them and match. uClibc does not unbackslash,
+# error fails to match dirname, subsequently not expanding <pattern> in it.
+#endif
+
 #if !ENABLE_ASH_INTERNAL_GLOB
 # include <glob.h>
 #endif