From: Christian Grothoff <christian@grothoff.org>
Date: Thu, 16 Feb 2012 18:30:18 +0000 (+0000)
Subject: -comments
X-Git-Tag: initial-import-from-subversion-38251~14832
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=18805673bf25fb6924280a54754e240a1402f46f;p=oweals%2Fgnunet.git

-comments
---

diff --git a/src/gns/gns.h b/src/gns/gns.h
index e35df7858..695722b78 100644
--- a/src/gns/gns.h
+++ b/src/gns/gns.h
@@ -42,15 +42,18 @@ struct GNUNET_GNS_ClientLookupMessage
   /**
    * Unique identifier for this request (for key collisions).
    */
+  // FIXME: unaligned
   uint64_t unique_id;
 
   /**
    * the type of record to look up
    */
+  // FIXME: bad type
   int type;
 
   /**
    * Length of name to lookup
+   * // FIXME: redundant
    */
   uint32_t namelen;
 
@@ -71,18 +74,21 @@ struct GNUNET_GNS_ClientResultMessage
   /**
    * Unique identifier for this request (for key collisions).
    */
+  // FIXME: unaligned
   uint64_t unique_id;
 
   /**
    * A key. TODO some uid
+   * // FIXME: why hash?
    */
   GNUNET_HashCode key;
 
   /**
    * The number of records contained in response
-   */
+   */  
   uint32_t num_records;
 
+  // FIXME: what format has a GNS_Record?
   /* followed by num_records GNUNET_GNS_Records*/
 
 };
diff --git a/src/include/gnunet_gns_service.h b/src/include/gnunet_gns_service.h
index 99028f60c..780ddbcca 100644
--- a/src/include/gnunet_gns_service.h
+++ b/src/include/gnunet_gns_service.h
@@ -22,8 +22,14 @@
  * @file include/gnunet_gns_service.h
  * @brief API to the GNS service
  * @author Martin Schanzenbach
+ *
+ * TODO:
+ * - decide what goes into storage API and what into GNS-service API
+ * - decide where to pass/expose/check keys / signatures
+ * - are GNS private keys per peer or per user?
  */
 
+
 #ifndef GNUNET_GNS_SERVICE_H
 #define GNUNET_GNS_SERVICE_H