From: Peter Howkins Date: Fri, 13 Jul 2018 17:36:50 +0000 (+0100) Subject: dtcm: Coverity 89160 X-Git-Tag: 2.3.0a~87 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=1563031cd8262168856d5ffa4a489ac942574550;p=oweals%2Fcde.git dtcm: Coverity 89160 --- diff --git a/cde/programs/dtcm/server/rtable3.c b/cde/programs/dtcm/server/rtable3.c index 855b5d93..9a03703b 100644 --- a/cde/programs/dtcm/server/rtable3.c +++ b/cde/programs/dtcm/server/rtable3.c @@ -255,12 +255,14 @@ _DtCm_rtable_change_instance_3_svc(Table_Args_3 *args, struct svc_req *svcrq) if (res!=NULL) xdr_free ((xdrproc_t)_DtCm_xdr_Table_Res_3, (char*)res); res = NULL; - newargs = _DtCm_tableargs3_to_tableargs4(args); - newargs->args.Args_4_u.apptid.option = do_one_4; - newres = _DtCm_rtable_change_4_svc(newargs, svcrq); - res = _DtCm_tableres4_to_tableres3(newres); + newargs = _DtCm_tableargs3_to_tableargs4(args); + if(newargs) { + newargs->args.Args_4_u.apptid.option = do_one_4; + newres = _DtCm_rtable_change_4_svc(newargs, svcrq); + res = _DtCm_tableres4_to_tableres3(newres); - if (newargs!=NULL) xdr_free((xdrproc_t)_DtCm_xdr_Table_Args_4, (char*)newargs); + xdr_free((xdrproc_t)_DtCm_xdr_Table_Args_4, (char*)newargs); + } return(res); }