From: Daniel Dickinson <crazycshore@gmail.com>
Date: Mon, 12 Jul 2010 16:35:39 +0000 (+0000)
Subject: block-mount: Fixed two bugs in fstab.init. /etc/fstab was used where /tmp/fstab shoul... 
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=117590a2ce8ffc8161aafce06164e02d1f34157e;p=librecmc%2Flibrecmc.git

block-mount: Fixed two bugs in fstab.init. /etc/fstab was used where /tmp/fstab should have been, and locking was insufficiently careful and was such that it could result in deadlock when hotplug was in use.

SVN-Revision: 22148
---

diff --git a/package/block-mount/files/fstab.init b/package/block-mount/files/fstab.init
index d755eccf08..fdcd4f52a2 100644
--- a/package/block-mount/files/fstab.init
+++ b/package/block-mount/files/fstab.init
@@ -41,9 +41,13 @@ do_swapoff() {
 start() {
 	config_load fstab
 	mkdir -p /var/lock
-	lock /var/lock/fstab.lck
-	echo '# WARNING: this is an auto generated file, please use uci to set defined filesystems' > /etc/fstab
-	lock -u /var/lock/fstab.lck
+	lock -w /var/lock/fstab.lck && {
+		lock /var/lock/fstab.lck
+		[ -e /tmp/fstab ] || { 
+			echo '# WARNING: this is an auto generated file, please use uci to set defined filesystems' > /tmp/fstab
+		}
+		lock -u /var/lock/fstab.lck
+	}
 	config_foreach do_swapon swap
 	config_foreach do_mount mount
 }