From: Felix Fietkau <nbd@openwrt.org>
Date: Sun, 1 Feb 2015 08:20:37 +0000 (+0000)
Subject: ramips: fix ethernet driver tx completion polling
X-Git-Tag: reboot~4464
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=10c8d8c4833c178b4a30871f020637c7ba94d014;p=oweals%2Fopenwrt.git

ramips: fix ethernet driver tx completion polling

- budget is decremented with completed frames, so don't check if done is
smaller
- ACK the interrupt before processing further frames to fix a small race
condition.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 44234
---

diff --git a/target/linux/ramips/files/drivers/net/ethernet/ralink/ralink_soc_eth.c b/target/linux/ramips/files/drivers/net/ethernet/ralink/ralink_soc_eth.c
index 9900a5e508..12c6ccaf98 100644
--- a/target/linux/ramips/files/drivers/net/ethernet/ralink/ralink_soc_eth.c
+++ b/target/linux/ramips/files/drivers/net/ethernet/ralink/ralink_soc_eth.c
@@ -902,11 +902,11 @@ txpoll_again:
 	if (!done)
 		return 0;
 
-	if (done < budget) {
+	if (budget) {
+		fe_reg_w32(tx_intr, FE_REG_FE_INT_STATUS);
 		hwidx = fe_reg_r32(FE_REG_TX_DTX_IDX0);
 		if (idx != hwidx)
 			goto txpoll_again;
-		fe_reg_w32(tx_intr, FE_REG_FE_INT_STATUS);
 	}
 
 	netdev_completed_queue(netdev, done, bytes_compl);