From: Andy Polyakov <appro@openssl.org>
Date: Sun, 30 Sep 2007 19:15:46 +0000 (+0000)
Subject: DTLS RFC4347 requires client to use rame random field in reply to
X-Git-Tag: OpenSSL_0_9_8f~12
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=0fc3d51b7dc65e27484c3a22f27d14388bb7c208;p=oweals%2Fopenssl.git

DTLS RFC4347 requires client to use rame random field in reply to
HelloVerifyRequest [from HEAD].
---

diff --git a/ssl/d1_clnt.c b/ssl/d1_clnt.c
index 6efb248dc8..8d2b9a6ea8 100644
--- a/ssl/d1_clnt.c
+++ b/ssl/d1_clnt.c
@@ -219,6 +219,8 @@ int dtls1_connect(SSL *s)
 			s->state=SSL3_ST_CW_CLNT_HELLO_A;
 			s->ctx->stats.sess_connect++;
 			s->init_num=0;
+			/* mark client_random uninitialized */
+			memset(s->s3->client_random,0,sizeof(s->s3->client_random));
 			break;
 
 		case SSL3_ST_CW_CLNT_HELLO_A:
@@ -422,6 +424,9 @@ int dtls1_connect(SSL *s)
 				s->s3->tmp.next_state=SSL3_ST_CR_FINISHED_A;
 				}
 			s->init_num=0;
+			/* mark client_random uninitialized */
+			memset (s->s3->client_random,0,sizeof(s->s3->client_random));
+
 			break;
 
 		case SSL3_ST_CR_FINISHED_A:
@@ -544,9 +549,15 @@ int dtls1_client_hello(SSL *s)
 		/* else use the pre-loaded session */
 
 		p=s->s3->client_random;
-		Time=(unsigned long)time(NULL);			/* Time */
-		l2n(Time,p);
-		RAND_pseudo_bytes(p,SSL3_RANDOM_SIZE-sizeof(Time));
+		/* if client_random is initialized, reuse it, we are
+		 * required to use same upon reply to HelloVerify */
+		for (i=0;p[i]=='\0' && i<sizeof(s->s3->client_random);i++) ;
+		if (i==sizeof(s->s3->client_random))
+			{
+			Time=(unsigned long)time(NULL);	/* Time */
+			l2n(Time,p);
+			RAND_pseudo_bytes(p,SSL3_RANDOM_SIZE-4);
+			}
 
 		/* Do the message type and length last */
 		d=p= &(buf[DTLS1_HM_HEADER_LENGTH]);