From: Michal Simek Date: Mon, 5 Oct 2015 10:49:48 +0000 (+0200) Subject: net: zynq: Fix clearing statistic X-Git-Tag: v2016.01-rc2~243^2~11 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=0ebf40417df79ca0b73fa3fca0f6d13f47c5b530;p=oweals%2Fu-boot.git net: zynq: Fix clearing statistic Previous loop was completely bogus. Iterration should go just over statistic counters. Signed-off-by: Michal Simek Acked-by: Joe Hershberger --- diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c index fae61a0fa0..41ac8295db 100644 --- a/drivers/net/zynq_gem.c +++ b/drivers/net/zynq_gem.c @@ -129,7 +129,8 @@ struct zynq_gem_regs { u32 laddr[4][LADDR_HIGH + 1]; /* 0x8c - Specific1 addr low/high reg */ u32 match[4]; /* 0xa8 - Type ID1 Match reg */ u32 reserved6[18]; - u32 stat[44]; /* 0x100 - Octects transmitted Low reg - stat start */ +#define STAT_SIZE 44 + u32 stat[STAT_SIZE]; /* 0x100 - Octects transmitted Low reg */ }; /* BD descriptors */ @@ -301,8 +302,6 @@ static int zynq_gem_init(struct eth_device *dev, bd_t * bis) u32 i; unsigned long clk_rate = 0; struct phy_device *phydev; - const u32 stat_size = (sizeof(struct zynq_gem_regs) - - offsetof(struct zynq_gem_regs, stat)) / 4; struct zynq_gem_regs *regs = (struct zynq_gem_regs *)dev->iobase; struct zynq_gem_priv *priv = dev->priv; const u32 supported = SUPPORTED_10baseT_Half | @@ -330,7 +329,7 @@ static int zynq_gem_init(struct eth_device *dev, bd_t * bis) writel(0x0, ®s->hashh); /* Clear all counters */ - for (i = 0; i <= stat_size; i++) + for (i = 0; i < STAT_SIZE; i++) readl(®s->stat[i]); /* Setup RxBD space */