From: Stefan Roese Date: Mon, 11 Feb 2019 06:53:34 +0000 (+0100) Subject: pci: pci_mvebu: Add comment about missing of_n_addr_cells() call X-Git-Tag: v2019.04~26^2~9 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=0df62e8da8f48d8bbabd1d92512173cbb424e3c5;p=oweals%2Fu-boot.git pci: pci_mvebu: Add comment about missing of_n_addr_cells() call This patch adds a comment to explain the use of the hardcoded value for the number of address cells in mvebu_get_tgt_attr(). This should help to rework this function, once CONFIG_OF_LIVE is enabled for MVEBU in general. Signed-off-by: Stefan Roese Cc: Bin Meng Signed-off-by: Stefan Roese --- diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c index 6026fa67f9..e21dc10c2f 100644 --- a/drivers/pci/pci_mvebu.c +++ b/drivers/pci/pci_mvebu.c @@ -369,6 +369,12 @@ static int mvebu_get_tgt_attr(ofnode node, int devfn, if (!range) return -EINVAL; + /* + * Linux uses of_n_addr_cells() to get the number of address cells + * here. Currently this function is only available in U-Boot when + * CONFIG_OF_LIVE is enabled. Until this is enabled for MVEBU in + * general, lets't hardcode the "pna" value in the U-Boot code. + */ pna = 2; /* hardcoded for now because of lack of of_n_addr_cells() */ rangesz = pna + na + ns; nranges = rlen / sizeof(__be32) / rangesz;