From: Matthias Schiffer Date: Thu, 4 Jan 2018 16:18:16 +0000 (+0100) Subject: scripts/package-metadata.pl: remove broken detection of self-dependencies X-Git-Tag: v18.06.0-rc1~1413 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=0b28cc56d4352f5a8b2e7783d3787e6effcdb630;p=oweals%2Fopenwrt.git scripts/package-metadata.pl: remove broken detection of self-dependencies A self-dependency is not an error worth a warning; rather, it is very common: whenever there are dependencies between different binary packages originating from the same source package, such dependencies occur. Not actually generating dependency rules is correct, but already handled a few lines below. A typo prevented this redundant rule from working, which is the reason the warning was not actually printed. Signed-off-by: Matthias Schiffer --- diff --git a/scripts/package-metadata.pl b/scripts/package-metadata.pl index 261490b868..fbd458bf2a 100755 --- a/scripts/package-metadata.pl +++ b/scripts/package-metadata.pl @@ -535,11 +535,6 @@ sub gen_package_mk() { $pkg->{makefile}, $pkg_dep->{src}, $deptype, $pkg_dep->{makefile}, $deptype; next; } - unless ($pkg->{src} ne $pkg_dep->{sec}.$suffix) { - warn sprintf "WARNING: Makefile '%s' has a build dependency on itself\n", - $pkg->{makefile}; - next; - } $idx = $pkg_dep->{subdir}.$pkg_dep->{src}; } elsif (defined($srcpackage{$dep})) { $idx = $subdir{$dep}.$dep;