From: Peng Fan <peng.fan@nxp.com>
Date: Tue, 22 Dec 2015 09:14:13 +0000 (+0800)
Subject: common: cli: avoid memory leak
X-Git-Tag: v2016.01-rc4~3
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=09a788624dbe32aeeb0d74c97c0965303eb96d8c;p=oweals%2Fu-boot.git

common: cli: avoid memory leak

Whether CONFIG_SYS_HUSH_PARSER is defined or not, should always
check to free 'buff' to avoid memory leak.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Simon Glass <sjg@chromium.org>
---

diff --git a/common/cli.c b/common/cli.c
index fbcd339c9b..119d282bc2 100644
--- a/common/cli.c
+++ b/common/cli.c
@@ -103,9 +103,9 @@ int run_command_list(const char *cmd, int len, int flag)
 	 * is pretty rare.
 	 */
 	rcode = cli_simple_run_command_list(buff, flag);
+#endif
 	if (need_buff)
 		free(buff);
-#endif
 
 	return rcode;
 }