From: Mathias Kresin Date: Thu, 31 Aug 2017 05:52:00 +0000 (+0200) Subject: kernel: rtl8306: fix port link status X-Git-Tag: v18.06.0-rc1~2291 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=096dff8fcdf4eeb0d94ea335b95a23b30f5d5f3d;p=oweals%2Fopenwrt.git kernel: rtl8306: fix port link status In case the link changes from down to up, the register is only updated on read. If the link failed/was down, this bit will be 0 until after reading this bit again. Fixes a reported link down by swconfig alebit the link is up (query for the link again will show the correct link status) Signed-off-by: Mathias Kresin --- diff --git a/target/linux/generic/files/drivers/net/phy/rtl8306.c b/target/linux/generic/files/drivers/net/phy/rtl8306.c index 7c70109e63..7bbac40617 100644 --- a/target/linux/generic/files/drivers/net/phy/rtl8306.c +++ b/target/linux/generic/files/drivers/net/phy/rtl8306.c @@ -592,7 +592,11 @@ rtl_get_port_link(struct switch_dev *dev, int port, struct switch_port_link *lin if (port >= RTL8306_NUM_PORTS) return -EINVAL; + /* in case the link changes from down to up, the register is only updated on read */ link->link = rtl_get(dev, RTL_PORT_REG(port, LINK)); + if (!link->link) + link->link = rtl_get(dev, RTL_PORT_REG(port, LINK)); + if (!link->link) return 0;