From: Rich Felker <dalias@aerifal.cx>
Date: Tue, 21 Apr 2015 17:24:46 +0000 (-0400)
Subject: fix mmap leak in sem_open failure path for link call
X-Git-Tag: v1.1.9~39
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=086793ad99dc625fd1c47f96fc31ea8aa316b438;p=oweals%2Fmusl.git

fix mmap leak in sem_open failure path for link call

the leak was found by static analysis (reported by Alexander Monakov),
not tested/observed, but seems to have occured both when failing due
to O_EXCL, and in a race condition with O_CREAT but not O_EXCL where a
semaphore by the same name was created concurrently.
---

diff --git a/src/thread/sem_open.c b/src/thread/sem_open.c
index ab884a42..fda0acd3 100644
--- a/src/thread/sem_open.c
+++ b/src/thread/sem_open.c
@@ -126,6 +126,7 @@ sem_t *sem_open(const char *name, int flags, ...)
 		e = link(tmp, name) ? errno : 0;
 		unlink(tmp);
 		if (!e) break;
+		munmap(map, sizeof(sem_t));
 		/* Failure is only fatal when doing an exclusive open;
 		 * otherwise, next iteration will try to open the
 		 * existing file. */