From: Andy Polyakov Date: Sat, 25 Mar 2017 09:58:57 +0000 (+0100) Subject: aes/asm/bsaes-armv7.pl: relax stack alignment requirement. X-Git-Tag: OpenSSL_1_1_1-pre1~1949 X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=0822d41b6d54132df96c02cc6f6fa9b179378351;p=oweals%2Fopenssl.git aes/asm/bsaes-armv7.pl: relax stack alignment requirement. Even though Apple refers to Procedure Call Standard for ARM Architecture (AAPCS), they apparently adhere to custom version that doesn't follow stack alignment constraints in the said standard. [Why or why? If it's vendor lock-in thing, then it would be like worst spot ever.] And since bsaes-armv7 relied on standard alignment, it became problematic to execute the code on iOS. Reviewed-by: Rich Salz --- diff --git a/crypto/aes/asm/bsaes-armv7.pl b/crypto/aes/asm/bsaes-armv7.pl index 33295881e1..ba641eb547 100644 --- a/crypto/aes/asm/bsaes-armv7.pl +++ b/crypto/aes/asm/bsaes-armv7.pl @@ -1365,7 +1365,7 @@ bsaes_cbc_encrypt: vmov @XMM[4],@XMM[15] @ just in case ensure that IV vmov @XMM[5],@XMM[0] @ and input are preserved bl AES_decrypt - vld1.8 {@XMM[0]}, [$fp,:64] @ load result + vld1.8 {@XMM[0]}, [$fp] @ load result veor @XMM[0], @XMM[0], @XMM[4] @ ^= IV vmov @XMM[15], @XMM[5] @ @XMM[5] holds input vst1.8 {@XMM[0]}, [$rounds] @ write output