From: Paramat <paramat@users.noreply.github.com>
Date: Tue, 17 Apr 2018 21:25:59 +0000 (+0100)
Subject: Cavegen: Fix variable typo that broke mgvalleys large cave distribution (#7249)
X-Git-Tag: 0.4.17~11
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=0414322d23f1a4393e909dd075771691603838f3;p=oweals%2Fminetest.git

Cavegen: Fix variable typo that broke mgvalleys large cave distribution (#7249)

Fix elusive 5 year old bug that caused mgvalleys large caves to be flat and
limited to mapchunk borders.
Error was fixed 2 years ago in 'CavesV6' but not in 'CavesRandomWalk'.
---

diff --git a/src/cavegen.cpp b/src/cavegen.cpp
index dbed79951..07fb629e2 100644
--- a/src/cavegen.cpp
+++ b/src/cavegen.cpp
@@ -332,7 +332,7 @@ void CavesRandomWalk::makeCave(MMVManip *vm, v3s16 nmin, v3s16 nmax,
 
 	route_y_min = 0;
 	// Allow half a diameter + 7 over stone surface
-	route_y_max = -of.Y + max_stone_y + max_tunnel_diameter / 2 + 7;
+	route_y_max = -of.Y + max_stone_height + max_tunnel_diameter / 2 + 7;
 
 	// Limit maximum to area
 	route_y_max = rangelim(route_y_max, 0, ar.Y - 1);
diff --git a/src/cavegen.h b/src/cavegen.h
index a1140594e..1cb8dd90d 100644
--- a/src/cavegen.h
+++ b/src/cavegen.h
@@ -134,7 +134,6 @@ public:
 	bool large_cave_is_flat;
 	bool flooded;
 
-	s16 max_stone_y;
 	v3s16 node_min;
 	v3s16 node_max;