From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Wed, 13 Jan 2010 13:53:49 +0000 (+0100)
Subject: builtin_read: note about better implementation
X-Git-Tag: 1_16_0~52
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=03d81ef43aca1808255d1a2a19ec394ed805eee8;p=oweals%2Fbusybox.git

builtin_read: note about better implementation

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---

diff --git a/shell/builtin_read.c b/shell/builtin_read.c
index 412bcf869..73b0949cf 100644
--- a/shell/builtin_read.c
+++ b/shell/builtin_read.c
@@ -20,6 +20,11 @@
 #include "shell_common.h"
 #include "builtin_read.h"
 
+//TODO: use more efficient setvar() which takes a pointer to malloced "VAR=VAL"
+//string. hush naturally has it, and ash has setvareq().
+//Here we can simply store "VAR=" at buffer start and store read data directly
+//after "=", then pass buffer to setvar() to consume.
+
 const char* FAST_FUNC
 shell_builtin_read(void FAST_FUNC (*setvar)(const char *name, const char *val),
 	char       **argv,