From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue, 15 Oct 2019 19:46:03 +0000 (+0200)
Subject: lib: errno: check for unsupported error number
X-Git-Tag: v2020.01-rc2~28^2~16
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=02e8a8241bb5fff315f3e721992220428f288b6d;p=oweals%2Fu-boot.git

lib: errno: check for unsupported error number

If errno_str() is called with an unsupported error number, do not return a
random pointer but a reasonable text.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/lib/errno_str.c b/lib/errno_str.c
index 0ba950e970..bb8f9fbeb3 100644
--- a/lib/errno_str.c
+++ b/lib/errno_str.c
@@ -136,6 +136,8 @@ static const char * const errno_message[] = {
 	ERRNO_MSG(EDQUOT, "Quota exceeded"),
 	ERRNO_MSG(ENOMEDIUM, "No medium found"),
 	ERRNO_MSG(EMEDIUMTYPE, "Wrong medium type"),
+	/* Message for unsupported error numbers */
+	ERRNO_MSG(0, "Unknown error"),
 };
 
 const char *errno_str(int errno)
@@ -143,5 +145,9 @@ const char *errno_str(int errno)
 	if (errno >= 0)
 		return errno_message[0];
 
-	return errno_message[abs(errno)];
+	errno = -errno;
+	if (errno >= ARRAY_SIZE(errno_message))
+		errno = ARRAY_SIZE(errno_message) - 1;
+
+	return errno_message[errno];
 }