From: Jan Hykel <jan.hykel@acision.com>
Date: Sun, 16 Nov 2014 16:51:17 +0000 (+0000)
Subject: Don't use msg on error.
X-Git-Tag: master-post-reformat~296
X-Git-Url: https://git.librecmc.org/?a=commitdiff_plain;h=012aa9ec76b158179b4de44bb5de8b8472045eac;p=oweals%2Fopenssl.git

Don't use msg on error.

Don't attempt to access msg structure if recvmsg returns an error.

PR#3483
Reviewed-by: Stephen Henson <steve@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
---

diff --git a/crypto/bio/bss_dgram.c b/crypto/bio/bss_dgram.c
index 8a55c1521b..8a1eb6de8b 100644
--- a/crypto/bio/bss_dgram.c
+++ b/crypto/bio/bss_dgram.c
@@ -1082,6 +1082,13 @@ static int dgram_sctp_read(BIO *b, char *out, int outl)
 			msg.msg_flags = 0;
 			n = recvmsg(b->num, &msg, 0);
 
+			if (n <= 0)
+				{
+				if (n < 0)
+					ret = n;
+				break;
+				}
+
 			if (msg.msg_controllen > 0)
 				{
 				for (cmsg = CMSG_FIRSTHDR(&msg); cmsg; cmsg = CMSG_NXTHDR(&msg, cmsg))
@@ -1121,13 +1128,6 @@ static int dgram_sctp_read(BIO *b, char *out, int outl)
 					}
 				}
 
-			if (n <= 0)
-				{
-				if (n < 0)
-					ret = n;
-				break;
-				}
-
 			if (msg.msg_flags & MSG_NOTIFICATION)
 				{
 				snp = (union sctp_notification*) out;