luci-mod-network: add certificate subj validation 3444/head
authorDavid Lam <david@thedavid.net>
Sun, 12 Jan 2020 08:01:41 +0000 (00:01 -0800)
committerDavid Lam <david@thedavid.net>
Sun, 12 Jan 2020 08:33:43 +0000 (00:33 -0800)
This PR is tied to changes being made via openwrt/openwrt#2654, and it
allows users to provide certificate constraint(s) when connecting as a
STA to an AP using Enterprise modes. The constraints can either be
provided via the certificate's X509 subject using a substring (e.g.
/CN=wifi.mycompany.com) or subject alternate name values (e.g.
DNS:wifi.mycompany.com), although both can be combined for a stricter
validation criteria. Other options, such as wildcard and exact domain
matches are also available.

Signed-off-by: David Lam <david@thedavid.net>
modules/luci-mod-network/htdocs/luci-static/resources/view/network/wireless.js

index 61838a23631c5d841656818427e32b431abf01f9..54786d36a0ac2a81c6a4fc56fb3a50e3bff74df8 100644 (file)
@@ -1434,6 +1434,30 @@ return L.view.extend({
                                        o.depends({ mode: 'sta-wds', encryption: 'wpa' });
                                        o.depends({ mode: 'sta-wds', encryption: 'wpa2' });
 
+                                       o = ss.taboption('encryption', form.Value, 'subject_match', _('Certificate constraint (Subject)'), _("Certificate constraint substring - e.g. /CN=wifi.mycompany.com<br />See `logread -f` during handshake for actual values"));
+                                       o.depends({ mode: 'sta', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta', encryption: 'wpa2' });
+                                       o.depends({ mode: 'sta-wds', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta-wds', encryption: 'wpa2' });
+
+                                       o = ss.taboption('encryption', form.DynamicList, 'altsubject_match', _('Certificate constraint (SAN)'), _("Certificate constraint(s) via Subject Alternate Name values<br />(supported attributes: EMAIL, DNS, URI) - e.g. DNS:wifi.mycompany.com"));
+                                       o.depends({ mode: 'sta', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta', encryption: 'wpa2' });
+                                       o.depends({ mode: 'sta-wds', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta-wds', encryption: 'wpa2' });
+
+                                       o = ss.taboption('encryption', form.DynamicList, 'domain_match', _('Certificate constraint (Domain)'), _("Certificate constraint(s) against DNS SAN values (if available)<br />or Subject CN (exact match)"));
+                                       o.depends({ mode: 'sta', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta', encryption: 'wpa2' });
+                                       o.depends({ mode: 'sta-wds', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta-wds', encryption: 'wpa2' });
+
+                                       o = ss.taboption('encryption', form.DynamicList, 'domain_suffix_match', _('Certificate constraint (Wildcard)'), _("Certificate constraint(s) against DNS SAN values (if available)<br />or Subject CN (suffix match)"));
+                                       o.depends({ mode: 'sta', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta', encryption: 'wpa2' });
+                                       o.depends({ mode: 'sta-wds', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta-wds', encryption: 'wpa2' });
+
                                        o = ss.taboption('encryption', form.FileUpload, 'client_cert', _('Path to Client-Certificate'));
                                        o.depends({ mode: 'sta', eap_type: 'tls', encryption: 'wpa' });
                                        o.depends({ mode: 'sta', eap_type: 'tls', encryption: 'wpa2' });
@@ -1491,6 +1515,30 @@ return L.view.extend({
                                        o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa' });
                                        o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa2' });
 
+                                       o = ss.taboption('encryption', form.Value, 'subject_match2', _('Inner certificate constraint (Subject)'), _("Certificate constraint substring - e.g. /CN=wifi.mycompany.com<br />See `logread -f` during handshake for actual values"));
+                                       o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa2' });
+                                       o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa2' });
+
+                                       o = ss.taboption('encryption', form.DynamicList, 'altsubject_match2', _('Inner certificate constraint (SAN)'), _("Certificate constraint(s) via Subject Alternate Name values<br />(supported attributes: EMAIL, DNS, URI) - e.g. DNS:wifi.mycompany.com"));
+                                       o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa2' });
+                                       o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa2' });
+
+                                       o = ss.taboption('encryption', form.DynamicList, 'domain_match2', _('Inner certificate constraint (Domain)'), _("Certificate constraint(s) against DNS SAN values (if available)<br />or Subject CN (exact match)"));
+                                       o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa2' });
+                                       o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa2' });
+
+                                       o = ss.taboption('encryption', form.DynamicList, 'domain_suffix_match2', _('Inner certificate constraint (Wildcard)'), _("Certificate constraint(s) against DNS SAN values (if available)<br />or Subject CN (suffix match)"));
+                                       o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa2' });
+                                       o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa' });
+                                       o.depends({ mode: 'sta-wds', auth: 'EAP-TLS', encryption: 'wpa2' });
+
                                        o = ss.taboption('encryption', form.FileUpload, 'client_cert2', _('Path to inner Client-Certificate'));
                                        o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa' });
                                        o.depends({ mode: 'sta', auth: 'EAP-TLS', encryption: 'wpa2' });