bootm: Add the missing PREP stage to bootz and correct image handling
authorSimon Glass <sjg@chromium.org>
Thu, 4 Jul 2013 20:26:11 +0000 (13:26 -0700)
committerTom Rini <trini@ti.com>
Wed, 10 Jul 2013 13:15:14 +0000 (09:15 -0400)
In the recent bootm refactor, the PREP stage was missing in the bootz
command. This causes unpredictable behaviour.

The use of a local variable means that the reset of cmd_bootm.c does not
in fact use the same image structure, so remove this.

Also manually set the OS type to Linux, since this is the only possibility
at present, and we need to select the right boot function.

Signed-off-by: Simon Glass <sjg@chromium.org>
common/cmd_bootm.c

index 3383a8c4c491460b34503c6724458346d66cd8ee..70d9891faff884c854ca43c9783b1bd6e685f0e9 100644 (file)
@@ -1791,7 +1791,6 @@ static int bootz_start(cmd_tbl_t *cmdtp, int flag, int argc,
 
 int do_bootz(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
-       bootm_headers_t images;
        int ret;
 
        if (bootz_start(cmdtp, flag, argc, argv, &images))
@@ -1803,8 +1802,10 @@ int do_bootz(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
         */
        bootm_disable_interrupts();
 
+       images.os.os = IH_OS_LINUX;
        ret = do_bootm_states(cmdtp, flag, argc, argv,
-                             BOOTM_STATE_OS_FAKE_GO | BOOTM_STATE_OS_GO,
+                             BOOTM_STATE_OS_PREP | BOOTM_STATE_OS_FAKE_GO |
+                             BOOTM_STATE_OS_GO,
                              &images, 1);
 
        return ret;