jffs2: fix searching for latest version in jffs2_1pass_list_inodes()
authorIlya Yanok <yanok@emcraft.com>
Thu, 13 Nov 2008 16:49:31 +0000 (19:49 +0300)
committerWolfgang Denk <wd@denx.de>
Tue, 9 Dec 2008 22:38:21 +0000 (23:38 +0100)
We need to update i_version inside cycle to find really latest version
inside jffs2_1pass_list_inodes(). With that fixed we can use isize inside
dump_inode() instead of calling expensive jffs2_1pass_read_inode().

Signed-off-by: Alexey Neyman <avn@emcraft.com>
Signed-off-by: Ilya Yanok <yanok@emcraft.com>
fs/jffs2/jffs2_1pass.c

index 920d2fd453624e0e31e1671a92c853c35053c048..35743fc2f5f4958cb1cb59a528cb8d692e260e32 100644 (file)
@@ -940,9 +940,7 @@ static inline u32 dump_inode(struct b_lists * pL, struct jffs2_raw_dirent *d, st
        st.st_mtime = i->mtime;
        st.st_mode = i->mode;
        st.st_ino = i->ino;
-
-       /* neither dsize nor isize help us.. do it the long way */
-       st.st_size = jffs2_1pass_read_inode(pL, i->ino, NULL);
+       st.st_size = i->isize;
 
        dump_stat(&st, fname);
 
@@ -976,6 +974,7 @@ jffs2_1pass_list_inodes(struct b_lists * pL, u32 pino)
                                jNode = (struct jffs2_raw_inode *)
                                        get_fl_mem(b2->offset, sizeof(ojNode), &ojNode);
                                if (jNode->ino == jDir->ino && jNode->version >= i_version) {
+                                       i_version = jNode->version;
                                        if (i)
                                                put_fl_mem(i);