base-files: allow skipping of hash verification
authorJo-Philipp Wich <jo@mein.io>
Tue, 12 Dec 2017 13:55:11 +0000 (14:55 +0100)
committerJohn Crispin <john@phrozen.org>
Thu, 14 Dec 2017 08:29:31 +0000 (09:29 +0100)
When calling a download target, hash verification is now completely
skipped if we set PKG_HASH=skip.

This allows to easily bump package version:

$ make package/<mypackage>/download PKG_HASH=skip V=s
$ make package/<mypackage>/check FIXUP=1 V=s

This will download the new version of the package, and then automatically
update PKG_HASH with the hash of the new version.  Of course, it is still
the responsibility of the packager to ensure that the new tarball is
legitimate, because it is downloaded from a possibly untrusted source.

Fixes: b30ba14e ("scripts/download.pl: fail loudly if provided hash is unsupported")
Signed-off-by: Baptiste Jonglez <git@bitsofnetworks.org>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Acked-by: Stijn Tintel <stijn@linux-ipv6.be>
Signed-off-by: John Crispin <john@phrozen.org>
scripts/download.pl

index 775408934ab25c92b1c988c325c0effd8ff45e50..f5c3f71056d2f10b93b6c28960c199a7e10bff95 100755 (executable)
@@ -88,7 +88,7 @@ sub download_cmd($) {
 }
 
 my $hash_cmd = hash_cmd();
-$hash_cmd or die "Cannot find appropriate hash command, ensure the provided hash is either a MD5 or SHA256 checksum.\n";
+$hash_cmd or ($file_hash eq "skip") or die "Cannot find appropriate hash command, ensure the provided hash is either a MD5 or SHA256 checksum.\n";
 
 sub download
 {