busybox: fix uninitialized memory when displaying IPv6 addresses
authorFelix Fietkau <nbd@openwrt.org>
Mon, 18 Jan 2016 11:07:35 +0000 (12:07 +0100)
committerDenys Vlasenko <vda.linux@googlemail.com>
Mon, 1 Feb 2016 01:20:25 +0000 (02:20 +0100)
After commit 8e74adab0107658e3dc04ed342206272a284f43e
("libbb: make INET[6]_rresolve use sockaddr2{host,dotted}_noport")
INET_sprint6 uses more than just sin6_addr, it also tries to display the
scope id, which is uninitialized when called from ife_print6.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
networking/interface.c

index 24bd13c576866a57a120f1bc1ee1ea8f6053da5d..e5723b42830511c466fc193c912a1076846abae6 100644 (file)
@@ -881,6 +881,7 @@ static void ife_print6(struct interface *ptr)
                        sprintf(addr6, "%s:%s:%s:%s:%s:%s:%s:%s",
                                        addr6p[0], addr6p[1], addr6p[2], addr6p[3],
                                        addr6p[4], addr6p[5], addr6p[6], addr6p[7]);
+                       memset(&sap, 0, sizeof(sap));
                        inet_pton(AF_INET6, addr6,
                                          (struct sockaddr *) &sap.sin6_addr);
                        sap.sin6_family = AF_INET6;