early: remove superfluous close of stdio file descriptors
authorGabor Juhos <juhosg@openwrt.org>
Fri, 19 Jul 2013 06:21:17 +0000 (08:21 +0200)
committerJohn Crispin <blogic@openwrt.org>
Mon, 22 Jul 2013 06:18:50 +0000 (08:18 +0200)
'man dup2' says:

  dup2() makes newfd be the copy of oldfd, closing newfd first if
  necessary, but note the following:

  *  If oldfd is not a valid file descriptor, then the call fails,
     and newfd is not closed.

  *  If oldfd is a valid file descriptor, and newfd has the same
     value as oldfd, then dup2() does nothing, and returns newfd.

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
early.c

diff --git a/early.c b/early.c
index 204623b79ecc27ca2f357d8d83b4e0b319faf2bc..f9e3277933fc051e786ca0c4dc6df33e719d4d4c 100644 (file)
--- a/early.c
+++ b/early.c
@@ -53,10 +53,6 @@ static void early_console(const char *dev)
                mkdev("*console", 0600);
 
        dd = open(dev, O_RDWR);
-       close(STDIN_FILENO);
-       close(STDOUT_FILENO);
-       close(STDERR_FILENO);
-
        if (dd < 0) {
                ERROR("Failed to open %s\n", dev);
                return;