Marked probable bug, pointed out by Anonymous.

diff --git a/apps/pkcs12.c b/apps/pkcs12.c
index e41c5677a86f824aceab171412c9e07df35c3098..0fe519ff178863bc8eccbcb8ba409ae42bc04c1f 100644 (file)
--- a/apps/pkcs12.c
+++ b/apps/pkcs12.c
@@ -371,6 +371,8 @@ if (export_cert) {
 
        if (canames) sk_free(canames);
 
+       /* if (!pmatch) ...?  What should happen here?  XXX */
+
        if(!noprompt &&
                EVP_read_pw_string(pass, 50, "Enter Export Password:", 1)) {
            BIO_printf (bio_err, "Can't read Password\n");
@@ -421,7 +423,7 @@ if (export_cert) {
        ret = 0;
        goto end;
        
-}
+    }
 
     if (!(p12 = d2i_PKCS12_bio (in, NULL))) {
        ERR_print_errors(bio_err);