dtpdmd: Resolve some coverity warnings
authorPeter Howkins <flibble@users.sf.net>
Fri, 30 Mar 2018 22:48:00 +0000 (23:48 +0100)
committerPeter Howkins <flibble@users.sf.net>
Fri, 30 Mar 2018 22:48:00 +0000 (23:48 +0100)
cde/programs/dtpdmd/dtpdmd.c
cde/programs/dtpdmd/manager.c

index e4779440393419b3ff0f3c2afc45425b9a50903a..68b5dd0a0e380b847dbf7b2eb0b9d301ddcd5190 100644 (file)
@@ -162,6 +162,8 @@ static int generic_error_handler( edpy, eevent )
     g.xerrno  = eevent->error_code;
     g.xerrreq = eevent->request_code;
     g.xerrmin = eevent->minor_code;
+
+    return 0; /* XSetErrorHandler handlers return values are ignored */
 }
 
 /******************************************************************************
index b0f058641c1e3d25b37b06e2429f10bd9f1202b9..1c60e0af3583eb01c285742a2ed9b8850dcfe815 100644 (file)
@@ -475,7 +475,7 @@ void mgr_launch_pdm( XpPdmServiceRec *rec )
        /*
         * Set XAUTHORITY env var if needed.
         */
-       if ((rec->cookie_cnt) && (rec->auth_filename) && (rec->auth_file)) {
+       if ((rec->cookie_cnt) && (rec->auth_file)) {
            envstr = Xmalloc( strlen(rec->auth_filename) + 12 );
            sprintf( envstr, "XAUTHORITY=%s", rec->auth_filename );
            putenv( envstr );
@@ -513,7 +513,7 @@ void mgr_launch_pdm( XpPdmServiceRec *rec )
  */
 void mgr_fetch_pdm( XpPdmServiceRec *rec )
 {
-    char tstr[1024], *tptr1, *tptr2, *tptr3;
+    char tstr[1024], *tptr1 = NULL, *tptr2, *tptr3;
     int  firstTime;
     long now;
     Display *tdpy;