Bugfixes

1) a non NULL terminated buffer that can mess up output, spotted by Ian
Latter
2) in miscutils/strings.c: get rid of useless pointer dereference in
third part of for(;;), spotted by Larry Doolittle
3) bug when reading from a pipe and being invoked as strings
"cat Readme | strings" is broken
"cat Readme | busybox strings" works
spotted by Ian Latter and fixed by Tito.

diff --git a/miscutils/strings.c b/miscutils/strings.c
index 5dcd876e93ba67db10ef849c0ce446800f3b8400..92e9f0d1185be3979e938bc3826ea2dc19a6ca3b 100644 (file)
--- a/miscutils/strings.c
+++ b/miscutils/strings.c
@@ -67,7 +67,7 @@ int strings_main(int argc, char **argv)
        i=0;
 
        string=xmalloc(n+1);
-       /*string[n]='\0';*/
+       string[n]='\0';
        n-=1;
 
        if(argc==0)
@@ -77,7 +77,7 @@ int strings_main(int argc, char **argv)
                goto pipe;
        }
 
-       for(  ;*argv!=NULL;*argv++)
+       for( ;*argv!=NULL && argc>0;argv++)
        {
                if((file=bb_wfopen(*argv,"r")))
                {