Hideki IWAMOTO writes:

Current `tr' implementation has a problem, if `plain char' is signed.

[current cvs version]

>echo a | _install/usr/bin/tr '\0' '\377'
Segmentation fault (core dumped)

[patched version]

>echo a | _install/usr/bin/tr '\0' '\377'
a

diff --git a/coreutils/tr.c b/coreutils/tr.c
index 4e69dc89cb4123d8b8ae2c16824c06a43be4a1af..958fc80b85b0b25ad24960905206647115e0fab1 100644 (file)
--- a/coreutils/tr.c
+++ b/coreutils/tr.c
@@ -202,9 +202,9 @@ extern int tr_main(int argc, char **argv)
                        map(input, input_length, output, output_length);
                }
                for (i = 0; i < input_length; i++)
-                       invec[(int)input[i]] = TRUE;
+                       invec[(unsigned char)input[i]] = TRUE;
                for (i = 0; i < output_length; i++)
-                       outvec[(int)output[i]] = TRUE;
+                       outvec[(unsigned char)output[i]] = TRUE;
        }
        convert();
        return (0);