Fix some test cases

The tar tests still don't pass, but at least now it's because of
a problem with Busybox and not the tests themselves.

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

diff --git a/testsuite/makedevs.tests b/testsuite/makedevs.tests
index eb51410b33a44d43d14ae34460b8757f28b1861c..fd12460ec7d4b701a3e1d3d8d1ff6f7ce7c238b3 100755 (executable)
--- a/testsuite/makedevs.tests
+++ b/testsuite/makedevs.tests
@@ -4,6 +4,11 @@
 
 . ./testing.sh
 
+test x"`id -u`" = x"0" || {
+       echo "SKIPPED: makedevs (must be root to test this)"
+       exit 0
+}
+
 unset LANG
 unset LC_COLLATE
 unset LC_ALL

diff --git a/testsuite/printf.tests b/testsuite/printf.tests
index b48e293f48406a9a47a10b0f06bfa0754fdf5d02..9a3c8747361b139a6e7e6fec228bbab83ed5dd7d 100755 (executable)
--- a/testsuite/printf.tests
+++ b/testsuite/printf.tests
@@ -89,9 +89,9 @@ testing "printf understands %Ld" \
 
 testing "printf handles %d bad_input" \
        "${bb}printf '%d\n' 1 - 2 bad 3 123bad 4 2>&1; echo \$?" \
-"1\n""printf: -: invalid number\n""0\n"\
-"2\n""printf: bad: invalid number\n""0\n"\
-"3\n""printf: 123bad: invalid number\n""0\n"\
+"1\n""printf: invalid number '-'\n""0\n"\
+"2\n""printf: invalid number 'bad'\n""0\n"\
+"3\n""printf: invalid number '123bad'\n""0\n"\
 "4\n""1\n" \
        "" ""
 

diff --git a/testsuite/tar.tests b/testsuite/tar.tests
index cef16b65e55efe33707ef043319aa69f271a6f1b..8b2523ff14691f786af44e8125377056cdfcf19c 100755 (executable)
--- a/testsuite/tar.tests
+++ b/testsuite/tar.tests
@@ -55,11 +55,13 @@ rm -rf input_* test.tar 2>/dev/null
 chmod 741 input_hard1
 ln input_hard1 input_hard2
 mkdir input_dir
-chmod 550 input_dir
 ln input_hard1 input_dir
 ln input_hard2 input_dir
+chmod 550 input_dir
 tar cf test.tar input_*
 tar tvf test.tar | sed "s/.*[0-9] input/input/"
+chmod 770 input_dir
+rm -rf input_*
 tar xf test.tar 2>&1
 echo Ok: $?
 ls -l . input_dir/* | grep input_ | sed "s/\\(^[^ ]*\\) .* input/\\1 input/"
@@ -86,11 +88,13 @@ rm -rf input_* test.tar 2>/dev/null
 chmod 741 input_file
 ln -s input_file input_soft
 mkdir input_dir
-chmod 550 input_dir
 ln input_file input_dir
 ln input_soft input_dir
+chmod 550 input_dir
 tar cf test.tar input_*
 tar tvf test.tar | sed "s/.*[0-9] input/input/" | sort
+chmod 770 input_dir
+rm -rf input_*
 tar xf test.tar 2>&1
 echo Ok: $?
 ls -l . input_dir/* | grep input_ | sed "s/\\(^[^ ]*\\) .* input/\\1 input/"