power: fix: Do not execute pmic command when not all necessary parameters are passed
authorŁukasz Majewski <l.majewski@samsung.com>
Mon, 24 Feb 2014 12:33:08 +0000 (13:33 +0100)
committerTom Rini <trini@ti.com>
Mon, 24 Feb 2014 15:56:33 +0000 (10:56 -0500)
Lack of this check resulted in a data abort when CPU tried to execute the
following command (without further mandatory input): 'pmic MAX77686_PMIC'.

Only the 'pmic list' command requires one passed parameter.
Other require at least two valid parameters for correct operation.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
drivers/power/power_core.c

index 29ccc831af2d80c3bcc4cadb5f80b95170088015..fe1f3160218342cd30db9f10f103216a4b3d4ad4 100644 (file)
@@ -140,6 +140,9 @@ int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                return CMD_RET_SUCCESS;
        }
 
+       if (argc < 3)
+               return CMD_RET_USAGE;
+
        name = argv[1];
        cmd = argv[2];