power: regulator: Add limits checking while setting voltage
authorKeerthy <j-keerthy@ti.com>
Wed, 26 Oct 2016 08:12:31 +0000 (13:42 +0530)
committerSimon Glass <sjg@chromium.org>
Sat, 26 Nov 2016 00:58:09 +0000 (17:58 -0700)
Currently the specific set ops functions are directly
called without any check for voltage limits for a regulator.
Check for them and proceed.

Signed-off-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Fixed checking of voltate limits:
Signed-off-by: Simon Glass <sjg@chromium.org>
drivers/power/regulator/regulator-uclass.c

index d64400981fa9a4a9ff144d3415cbad4a8c4dc0b2..e48d2132889cfabf02b25f06d2227db5171f12bb 100644 (file)
@@ -41,6 +41,13 @@ int regulator_get_value(struct udevice *dev)
 int regulator_set_value(struct udevice *dev, int uV)
 {
        const struct dm_regulator_ops *ops = dev_get_driver_ops(dev);
+       struct dm_regulator_uclass_platdata *uc_pdata;
+
+       uc_pdata = dev_get_uclass_platdata(dev);
+       if (uc_pdata->min_uV != -ENODATA && uV < uc_pdata->min_uV)
+               return -EINVAL;
+       if (uc_pdata->max_uV != -ENODATA && uV > uc_pdata->max_uV)
+               return -EINVAL;
 
        if (!ops || !ops->set_value)
                return -ENOSYS;