EC_KEY_METHOD copy support

Reviewed-by: Richard Levitte <levitte@openssl.org>

diff --git a/crypto/ec/ec_key.c b/crypto/ec/ec_key.c
index e2681c9acb80ad2185b69d36e9529c564797cc2c..1b941b48449bde46d2c210208090803f86994963 100644 (file)
--- a/crypto/ec/ec_key.c
+++ b/crypto/ec/ec_key.c
@@ -132,6 +132,15 @@ EC_KEY *EC_KEY_copy(EC_KEY *dest, const EC_KEY *src)
         ECerr(EC_F_EC_KEY_COPY, ERR_R_PASSED_NULL_PARAMETER);
         return NULL;
     }
+    if (src->meth != dest->meth) {
+        if (dest->meth->finish)
+            dest->meth->finish(dest);
+#ifndef OPENSSL_NO_ENGINE
+        if (dest->engine && ENGINE_finish(dest->engine) == 0)
+            return 0;
+        dest->engine = NULL;
+#endif
+    }
     /* copy the parameters */
     if (src->group) {
         const EC_METHOD *meth = EC_GROUP_method_of(src->group);
@@ -182,12 +191,24 @@ EC_KEY *EC_KEY_copy(EC_KEY *dest, const EC_KEY *src)
     dest->version = src->version;
     dest->flags = src->flags;
 
+    if (src->meth != dest->meth) {
+#ifndef OPENSSL_NO_ENGINE
+        if (src->engine && ENGINE_init(src->engine) == 0)
+            return 0;
+        dest->engine = src->engine;
+#endif
+        dest->meth = src->meth;
+    }
+
+    if (src->meth->copy && src->meth->copy(dest, src) == 0)
+        return 0;
+
     return dest;
 }
 
 EC_KEY *EC_KEY_dup(const EC_KEY *ec_key)
 {
-    EC_KEY *ret = EC_KEY_new();
+    EC_KEY *ret = EC_KEY_new_method(ec_key->engine);
     if (ret == NULL)
         return NULL;
     if (EC_KEY_copy(ret, ec_key) == NULL) {

diff --git a/crypto/ec/ec_kmeth.c b/crypto/ec/ec_kmeth.c
index 77b4443fa3485fd4c0e21fbbd02b85e86cedfd4b..4581880b84d19018d3338aca926da12fff36523d 100644 (file)
--- a/crypto/ec/ec_kmeth.c
+++ b/crypto/ec/ec_kmeth.c
@@ -63,7 +63,7 @@
 static const EC_KEY_METHOD openssl_ec_key_method = {
     "OpenSSL EC_KEY method",
     0,
-    0,0,
+    0,0,0,
     ossl_ec_key_gen,
     ossl_ecdh_compute_key
 };

diff --git a/crypto/ec/ec_lcl.h b/crypto/ec/ec_lcl.h
index 3aaee31575c949b79e4db1bf46a123d67d03f439..2db8779c57984be20e98c4e9dd69b6631ddd3126 100644 (file)
--- a/crypto/ec/ec_lcl.h
+++ b/crypto/ec/ec_lcl.h
@@ -562,6 +562,7 @@ struct ec_key_method_st {
     int32_t flags;
     int (*init)(EC_KEY *key);
     void (*finish)(EC_KEY *key);
+    int (*copy)(EC_KEY *dest, const EC_KEY *src);
     int (*keygen)(EC_KEY *key);
     int (*compute_key)(void *out, size_t outlen, const EC_POINT *pub_key,
                        EC_KEY *ecdh,