net: sandbox: Move disabled flag into priv struct
authorJoe Hershberger <joe.hershberger@ni.com>
Wed, 26 Sep 2018 21:48:53 +0000 (16:48 -0500)
committerJoe Hershberger <joe.hershberger@ni.com>
Wed, 10 Oct 2018 17:28:56 +0000 (12:28 -0500)
Store the per-device data with the device.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
drivers/net/sandbox.c

index b71c8f88d94f7abe7090e644a69b34486dfc1127..60fe065ee530b3e3d0099c77c179e746d9c6da22 100644 (file)
@@ -19,17 +19,18 @@ DECLARE_GLOBAL_DATA_PTR;
  *
  * fake_host_hwaddr: MAC address of mocked machine
  * fake_host_ipaddr: IP address of mocked machine
+ * disabled: Will not respond
  * recv_packet_buffer: buffer of the packet returned as received
  * recv_packet_length: length of the packet returned as received
  */
 struct eth_sandbox_priv {
        uchar fake_host_hwaddr[ARP_HLEN];
        struct in_addr fake_host_ipaddr;
+       bool disabled;
        uchar *recv_packet_buffer;
        int recv_packet_length;
 };
 
-static bool disabled[8] = {false};
 static bool skip_timeout;
 
 /*
@@ -40,7 +41,16 @@ static bool skip_timeout;
  */
 void sandbox_eth_disable_response(int index, bool disable)
 {
-       disabled[index] = disable;
+       struct udevice *dev;
+       struct eth_sandbox_priv *priv;
+       int ret;
+
+       ret = uclass_get_device(UCLASS_ETH, index, &dev);
+       if (ret)
+               return;
+
+       priv = dev_get_priv(dev);
+       priv->disabled = disable;
 }
 
 /*
@@ -71,8 +81,7 @@ static int sb_eth_send(struct udevice *dev, void *packet, int length)
 
        debug("eth_sandbox: Send packet %d\n", length);
 
-       if (dev->seq >= 0 && dev->seq < ARRAY_SIZE(disabled) &&
-           disabled[dev->seq])
+       if (priv->disabled)
                return 0;
 
        if (ntohs(eth->et_protlen) == PROT_ARP) {
@@ -212,6 +221,7 @@ static int sb_eth_ofdata_to_platdata(struct udevice *dev)
                return -EINVAL;
        }
        memcpy(priv->fake_host_hwaddr, mac, ARP_HLEN);
+       priv->disabled = false;
 
        return 0;
 }