msh: style fixes

shell/README - a place to record things about busybox shells

diff --git a/shell/README b/shell/README
new file mode 100644 (file)
index 0000000..ea11743
--- /dev/null
+++ b/shell/README
@@ -0,0 +1,6 @@
+Various bits of what is known about busybox shells, in no particular order.
+
+2007-04-14
+lash, hush: both do setsid() and as a result don't have ctty!
+Ctrl-C doesn't work for any child (try rm -i), etc...
+lash: bare ">file" doesn't create a file (hush works)

diff --git a/shell/msh.c b/shell/msh.c
index ae18061d6ded8b2abdd1586c9930f70aa1d96a62..91e302fac298c7eb332ca27de1cf2ce87426301e 100644 (file)
--- a/shell/msh.c
+++ b/shell/msh.c
@@ -2117,7 +2117,6 @@ static struct op *newtp(void)
 
 static struct op *namelist(struct op *t)
 {
-
        DBGPRINTF7(("NAMELIST: enter, t=%p, type %s, iolist=%p\n", t,
                                T_CMD_NAMES[t->type], iolist));
 
@@ -2658,7 +2657,7 @@ static int execute(struct op *t, int *pin, int *pout, int act)
 
        };
 
-  broken:
+ broken:
        t->words = wp2;
        isbreak = 0;
        freehere(areanum);
@@ -2681,13 +2680,13 @@ static int execute(struct op *t, int *pin, int *pout, int act)
 
 typedef int (*builtin_func_ptr)(struct op *);
 
-static builtin_func_ptr inbuilt(const char *s) {
+static builtin_func_ptr inbuilt(const char *s)
+{
        const struct builtincmd *bp;
 
        for (bp = builtincmds; bp->name; bp++)
                if (strcmp(bp->name, s) == 0)
                        return bp->builtinfunc;
-
        return NULL;
 }
 
@@ -4379,8 +4378,7 @@ static struct wdblock *addword(char *wd, struct wdblock *wb)
        return wb;
 }
 
-static
-char **getwords(struct wdblock *wb)
+static char **getwords(struct wdblock *wb)
 {
        char **wd;
        int nb;