rockchip: video: vop: Fix rk_display_init() return error
authorEric Gao <eric.gao@rock-chips.com>
Tue, 2 May 2017 10:23:51 +0000 (18:23 +0800)
committerSimon Glass <sjg@chromium.org>
Wed, 10 May 2017 19:37:22 +0000 (13:37 -0600)
It's caused by the difference of clk_set_rate function implement between
rk3288 andd rk3399.

clk_set_rate() of rk3288 return 0 in normal condition.
clk_set_rate() of rk3399 return input parameter in normal condition.

So check clk_set_rate's return value by IS_ERR_VALUE.

Signed-off-by: Eric Gao <eric.gao@rock-chips.com>
drivers/video/rockchip/rk_vop.c

index bc02f800dc4cc080111528ef906628ec9540a258..c12c24b18d8f76fdf96c02408931b4eaa6184828 100644 (file)
@@ -244,7 +244,7 @@ int rk_display_init(struct udevice *dev, ulong fbbase,
        ret = clk_get_by_index(dev, 1, &clk);
        if (!ret)
                ret = clk_set_rate(&clk, timing.pixelclock.typ);
-       if (ret) {
+       if (IS_ERR_VALUE(ret)) {
                debug("%s: Failed to set pixel clock: ret=%d\n", __func__, ret);
                return ret;
        }