powerpc/mpc85xx: Fix compiling error for common/cmd_gpio.c
authorOleksandr G Zhadan <oleks@arcturusnetworks.com>
Tue, 28 Apr 2015 17:59:50 +0000 (13:59 -0400)
committerYork Sun <yorksun@freescale.com>
Mon, 4 May 2015 16:26:09 +0000 (09:26 -0700)
To replicate:
1. add to include/configs/p1_p2_rdb_pc.h "#define CONFIG_CMD_GPIO"
2. run `make P1020RDB-PC_defconfig`
3. run CROSS_COMPILE=powerpc-linux- make

and you will get:
common/built-in.o: In function `do_gpio':
u-boot/common/cmd_gpio.c:186: undefined reference to `gpio_request'
u-boot/common/cmd_gpio.c:194: undefined reference to `gpio_direction_input'
u-boot/common/cmd_gpio.c:195: undefined reference to `gpio_get_value'
u-boot/common/cmd_gpio.c:200: undefined reference to `gpio_get_value'
u-boot/common/cmd_gpio.c:203: undefined reference to `gpio_direction_output'
u-boot/common/cmd_gpio.c:209: undefined reference to `gpio_free

Signed-off-by: Michael Durrant <mdurrant@arcturusnetworks.com>
Signed-off-by: Oleksandr G Zhadan <oleks@arcturusnetworks.com>
Reviewed-by: York Sun <yorksun@freescale.com>
arch/powerpc/include/asm/arch-mpc85xx/gpio.h
arch/powerpc/include/asm/mpc85xx_gpio.h

index 8beed3037ab9de2045acf8fd5664ba4e65ebe8f3..71794a82fe13ffa986f652ef069e8f2b1c339056 100644 (file)
@@ -12,4 +12,6 @@
 #ifndef __ASM_ARCH_MX85XX_GPIO_H
 #define __ASM_ARCH_MX85XX_GPIO_H
 
+#include <asm/mpc85xx_gpio.h>
+
 #endif
index 87bb4a092b86cabd7e6f1550bc4401514dde29f8..1d0dad4ccbf78acb2c212dac7295806b34290259 100644 (file)
@@ -72,9 +72,10 @@ static inline int gpio_request(unsigned gpio, const char *label)
        return 0;
 }
 
-static inline void gpio_free(unsigned gpio)
+static inline int gpio_free(unsigned gpio)
 {
        /* Compatibility shim */
+       return 0;
 }
 
 static inline int gpio_direction_input(unsigned gpio)
@@ -97,12 +98,13 @@ static inline int gpio_get_value(unsigned gpio)
        return !!mpc85xx_gpio_get(1U << gpio);
 }
 
-static inline void gpio_set_value(unsigned gpio, int value)
+static inline int gpio_set_value(unsigned gpio, int value)
 {
        if (value)
                mpc85xx_gpio_set_high(1U << gpio);
        else
                mpc85xx_gpio_set_low(1U << gpio);
+       return 0;
 }
 
 static inline int gpio_is_valid(int gpio)