wget: add a note about bug 3625
authorDenys Vlasenko <vda.linux@googlemail.com>
Sat, 16 Apr 2011 17:31:08 +0000 (19:31 +0200)
committerDenys Vlasenko <vda.linux@googlemail.com>
Sat, 16 Apr 2011 17:31:08 +0000 (19:31 +0200)
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
networking/wget.c

index 3a4be98783380e5790788302c0d9e80df9f23a8d..df6d36358f69d833288aa8523938215c1878b543 100644 (file)
@@ -661,6 +661,12 @@ static void download_one_url(const char *url)
 
 #if ENABLE_FEATURE_WGET_AUTHENTICATION
                if (target.user) {
+//TODO: URL-decode "user:password" string before base64-encoding:
+//wget http://test:my%20pass@example.com should send
+// Authorization: Basic dGVzdDpteSBwYXNz
+//which decodes to "test:my pass", instead of what we send now:
+// Authorization: Basic dGVzdDpteSUyMHBhc3M=
+//Can reuse decodeString() from httpd.c
                        fprintf(sfp, "Proxy-Authorization: Basic %s\r\n"+6,
                                base64enc(target.user));
                }