Make contrib/scripts/lint-python.sh useful

diff --git a/contrib/scripts/lint-python.sh b/contrib/scripts/lint-python.sh
index 9f7e0462df3c4d3c6447cd106933000a58d6569f..3325460f64f83e499319615b1b1208f7e8ee16ca 100755 (executable)
--- a/contrib/scripts/lint-python.sh
+++ b/contrib/scripts/lint-python.sh
@@ -1,24 +1,76 @@
 #!/bin/sh
 # check python style (and 2 to 3 migration)
+#
+# behold, the worst lowest effort shell script
+# ...given that we have more generic checking
+# for executables in other scripts already
 
-rm python-lint.log
+existence()
+{
+    command -v "$1" >/dev/null 2>&1
+}
 
-if [ -e "python" ]
+# invoke from root of source!
+if [ $(basename $(pwd)) = "scripts" ]
 then
-    python --version >> python-lint.log
-fi
+   return 1
+else
+    if [ -e "python-lint.log" ]
+    then
+        rm "python-lint.log"
+    fi
 
-if [ -e "python2" ]
-then
-    python2 --version >> python-lint.log
-fi
+    if existence python;
+    then
+        python --version >> python-lint.log
+    fi
 
-if [ -e "python3" ]
-then
-    python3 --version >> python-lint.log
-fi
+    if existence python2;
+    then
+        python2 --version >> python-lint.log
+    fi
 
-flake8 >> python-lint.log
+    if existence python3;
+    then
+        python3 --version >> python-lint.log
+    fi
 
-2to3 -v -d . >> python-lint.log
-2to3 -v -p . >> python-lint.log
+    if existence python3.7;
+    then
+        python3.7 --version >> python-lint.log
+    fi
+
+    if existence flake8;
+    then
+        echo >> python-lint.log
+        echo "flake8:" >> python-lint.log
+        echo >> python-lint.log
+        flake8 >> python-lint.log
+    fi
+
+    if existence flake8-3.7;
+    then
+        echo >> python-lint.log
+        echo "flake8:" >> python-lint.log
+        echo >> python-lint.log
+        flake8-3.7 >> python-lint.log
+    fi
+
+    if existence 2to3;
+    then
+        echo >> python-lint.log
+        echo "2to3" >> python-lint.log
+        echo >> python-lint.log
+        2to3 -v -d . >> python-lint.log
+        2to3 -v -p . >> python-lint.log
+    fi
+
+    if existence 2to3-3.7;
+    then
+        echo >> python-lint.log
+        echo "2to3" >> python-lint.log
+        echo >> python-lint.log
+        2to3-3.7 -v -d . >> python-lint.log
+        2to3-3.7 -v -p . >> python-lint.log
+    fi
+fi