Fix lint

diff --git a/server/controllers/api/users.ts b/server/controllers/api/users.ts
index a7528328ad39f2866b2933bb7bd87ff1dfd951f7..b49d37d4e7250a696ab28e3ffee53d3c229f0fa6 100644 (file)
--- a/server/controllers/api/users.ts
+++ b/server/controllers/api/users.ts
@@ -196,7 +196,7 @@ async function updateMe (req: express.Request, res: express.Response, next: expr
 
   await user.save()
 
-  return await res.sendStatus(204)
+  return res.sendStatus(204)
 }
 
 async function updateUser (req: express.Request, res: express.Response, next: express.NextFunction) {

diff --git a/server/controllers/api/videos/index.ts b/server/controllers/api/videos/index.ts
index 7ebbf4d6ebf4e09b10b70e7f24ccf4bcc3288ff7..9e233a8cc3eafb5674bd4cb8c25e1b9b9eea2168 100644 (file)
--- a/server/controllers/api/videos/index.ts
+++ b/server/controllers/api/videos/index.ts
@@ -41,7 +41,7 @@ import {
   getVideoFileHeight,
   resetSequelizeInstance
 } from '../../../helpers'
-import { TagInstance, VideoInstance } from '../../../models'
+import { VideoInstance } from '../../../models'
 import { VideoCreate, VideoUpdate } from '../../../../shared'
 
 import { abuseVideoRouter } from './abuse'

diff --git a/server/helpers/peertube-crypto.ts b/server/helpers/peertube-crypto.ts
index 47f0243e7e5ee5bb4daeb5640d7b848659a62738..fbc3bdcc2cb84c31db2e9957376cb5b6cb80fce2 100644 (file)
--- a/server/helpers/peertube-crypto.ts
+++ b/server/helpers/peertube-crypto.ts
@@ -58,7 +58,7 @@ async function sign (data: string|Object) {
   sign.update(dataString, 'utf8')
 
   const myKey = await getMyPrivateCert()
-  return await sign.sign(myKey, SIGNATURE_ENCODING)
+  return sign.sign(myKey, SIGNATURE_ENCODING)
 }
 
 function comparePassword (plainPassword: string, hashPassword: string) {
@@ -68,7 +68,7 @@ function comparePassword (plainPassword: string, hashPassword: string) {
 async function createCertsIfNotExist () {
   const exist = await certsExist()
   if (exist === true) {
-    return undefined
+    return
   }
 
   return await createCerts()

diff --git a/server/initializers/database.ts b/server/initializers/database.ts
index ade72b62f0941df889813420aaf48ab190fd3332..b410b0c18067879d4828b403434703551e3474b0 100644 (file)
--- a/server/initializers/database.ts
+++ b/server/initializers/database.ts
@@ -96,7 +96,7 @@ database.init = async (silent: boolean) => {
 
   if (!silent) logger.info('Database %s is ready.', dbname)
 
-  return undefined
+  return
 }
 
 // ---------------------------------------------------------------------------

diff --git a/server/lib/request/abstract-request-scheduler.ts b/server/lib/request/abstract-request-scheduler.ts
index f46682824bd26083cd12c89d0a4ad9e5849e4b17..08e371a0273b73c477d83bb7d77848e3fad89714 100644 (file)
--- a/server/lib/request/abstract-request-scheduler.ts
+++ b/server/lib/request/abstract-request-scheduler.ts
@@ -146,7 +146,7 @@ abstract class AbstractRequestScheduler <T> {
     this.afterRequestsHook()
 
     // All the requests were made, we update the pods score
-    await db.Pod.updatePodsScore(goodPods, badPods)
+    db.Pod.updatePodsScore(goodPods, badPods)
   }
 
   protected afterRequestHook () {

diff --git a/server/lib/request/request-video-qadu-scheduler.ts b/server/lib/request/request-video-qadu-scheduler.ts
index a54efc111bfad402cad8ab2197333c590a04a2f8..24ee59d29809253bc9a89c5d87760b46e13fc155 100644 (file)
--- a/server/lib/request/request-video-qadu-scheduler.ts
+++ b/server/lib/request/request-video-qadu-scheduler.ts
@@ -95,7 +95,7 @@ class RequestVideoQaduScheduler extends AbstractRequestScheduler<RequestsVideoQa
 
         default:
           logger.error('Unknown request video QADU type %s.', request.type)
-          return
+          return undefined
         }
 
         // Do not forget the uuid so the remote pod can identify the video

diff --git a/server/middlewares/validators/videos.ts b/server/middlewares/validators/videos.ts
index 8a9b383b88c567abf1b0db3f1eb5d7673a2a24f4..a032d14ce5938abcbef36aca780dd28d9aa746fb 100644 (file)
--- a/server/middlewares/validators/videos.ts
+++ b/server/middlewares/validators/videos.ts
@@ -79,7 +79,7 @@ const videosAddValidator = [
         })
         .then(duration => {
           // Previous test failed, abort
-          if (duration === undefined) return
+          if (duration === undefined) return undefined
 
           if (!isVideoDurationValid('' + duration)) {
             return res.status(400)

diff --git a/server/models/video/video-interface.ts b/server/models/video/video-interface.ts
index 4b5ae08c20f2a6bcb77f0caa5b7cc05ceff403a9..dd457bb00620ff476573fc74a1b707ba50c22605 100644 (file)
--- a/server/models/video/video-interface.ts
+++ b/server/models/video/video-interface.ts
@@ -1,7 +1,6 @@
 import * as Sequelize from 'sequelize'
 import * as Promise from 'bluebird'
 
-import { AuthorInstance } from './author-interface'
 import { TagAttributes, TagInstance } from './tag-interface'
 import { VideoFileAttributes, VideoFileInstance } from './video-file-interface'
 

diff --git a/server/tests/api/check-params/video-channels.ts b/server/tests/api/check-params/video-channels.ts
index b99b5eda8b7933426c2f9cf6c132bda86bfcd1ec..b46b90c146df0312ca142cd59ca0e9307ce1c69f 100644 (file)
--- a/server/tests/api/check-params/video-channels.ts
+++ b/server/tests/api/check-params/video-channels.ts
@@ -1,7 +1,6 @@
 /* tslint:disable:no-unused-expression */
 
 import * as request from 'supertest'
-import { join } from 'path'
 import 'mocha'
 import * as chai from 'chai'
 const expect = chai.expect

diff --git a/server/tests/api/video-channels.ts b/server/tests/api/video-channels.ts
index 95b202e2f678f8140a07002b4e09056f1e8b56fc..601b527ef7a544b18ba910aa0e310f20365e9a71 100644 (file)
--- a/server/tests/api/video-channels.ts
+++ b/server/tests/api/video-channels.ts
@@ -1,7 +1,5 @@
 /* tslint:disable:no-unused-expression */
 
-import { keyBy } from 'lodash'
-import { join } from 'path'
 import 'mocha'
 import * as chai from 'chai'
 const expect = chai.expect

diff --git a/tslint.json b/tslint.json
index 6e982ca85d47121cdfae366389a6502238b28d21..9acb2463040e9b88e8ef1a008247329f3d7ae705 100644 (file)
--- a/tslint.json
+++ b/tslint.json
@@ -1,6 +1,7 @@
 {
   "extends": "tslint-config-standard",
   "rules": {
+    "await-promise": [true, "Bluebird"],
     "no-inferrable-types": true,
     "eofline": true,
     "indent": ["spaces"],