hush: add a FIXME comment

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

diff --git a/shell/hush.c b/shell/hush.c
index 012ec219fd3c139bd5a60a165e9eb1831794dd02..e6dd1bc3d9421f9b2c33700d74d8fa777c35c105 100644 (file)
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -8173,6 +8173,12 @@ static NOINLINE int run_pipe(struct pipe *pi)
                rcode = 1; /* exitcode if redir failed */
                if (setup_redirects(command, &squirrel) == 0) {
                        debug_printf_exec(": run_list\n");
+//FIXME: we need to pass squirrel down into run_list()
+//for SH_STANDALONE case, or else this construct:
+// { find /proc/self/fd; true; } >FILE; cmd2
+//has no way of closing saved fd#1 for "find",
+//and in SH_STANDALONE mode, "find" is not execed,
+//therefore CLOEXEC on saved fd does not help.
                        rcode = run_list(command->group) & 0xff;
                }
                restore_redirects(squirrel);