tegra2: Rename PIN_ to PINGRP_
authorSimon Glass <sjg@chromium.org>
Wed, 21 Sep 2011 12:40:05 +0000 (12:40 +0000)
committerAlbert ARIBAUD <albert.u.boot@aribaud.net>
Thu, 27 Oct 2011 19:56:29 +0000 (21:56 +0200)
The pin groupings are better named PINGRP, since on Tegra2 they refer to
multiple pins.

Sorry about this, but better to get it right now when there is only a small
amount of code affected.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Tom Warren <twarren@nvidia.com>
arch/arm/cpu/armv7/tegra2/pinmux.c
arch/arm/include/asm/arch-tegra2/pinmux.h
board/nvidia/common/board.c

index 5594ab80f69c72b3702b139c39b399fbabba8485..01a3d841b8f4d2ae8c3e22cee06a9e6a31f92751 100644 (file)
@@ -27,7 +27,7 @@
 #include <common.h>
 
 
-void pinmux_set_tristate(enum pmux_pin pin, int enable)
+void pinmux_set_tristate(enum pmux_pingrp pin, int enable)
 {
        struct pmux_tri_ctlr *pmt = (struct pmux_tri_ctlr *)NV_PA_APB_MISC_BASE;
        u32 *tri = &pmt->pmt_tri[TRISTATE_REG(pin)];
@@ -41,12 +41,12 @@ void pinmux_set_tristate(enum pmux_pin pin, int enable)
        writel(reg, tri);
 }
 
-void pinmux_tristate_enable(enum pmux_pin pin)
+void pinmux_tristate_enable(enum pmux_pingrp pin)
 {
        pinmux_set_tristate(pin, 1);
 }
 
-void pinmux_tristate_disable(enum pmux_pin pin)
+void pinmux_tristate_disable(enum pmux_pingrp pin)
 {
        pinmux_set_tristate(pin, 0);
 }
index b8a4753c813f3debf7896829b8a1b68d41d3c471..e8ef632715e076d0f1265c711e31f7556a0caa7b 100644 (file)
 #ifndef _PINMUX_H_
 #define _PINMUX_H_
 
-/* Pins which we can set to tristate or normal */
-enum pmux_pin {
+/* Pin groups which we can set to tristate or normal */
+enum pmux_pingrp {
        /* APB_MISC_PP_TRISTATE_REG_A_0 */
-       PIN_ATA,
-       PIN_ATB,
-       PIN_ATC,
-       PIN_ATD,
-       PIN_CDEV1,
-       PIN_CDEV2,
-       PIN_CSUS,
-       PIN_DAP1,
-
-       PIN_DAP2,
-       PIN_DAP3,
-       PIN_DAP4,
-       PIN_DTA,
-       PIN_DTB,
-       PIN_DTC,
-       PIN_DTD,
-       PIN_DTE,
-
-       PIN_GPU,
-       PIN_GPV,
-       PIN_I2CP,
-       PIN_IRTX,
-       PIN_IRRX,
-       PIN_KBCB,
-       PIN_KBCA,
-       PIN_PMC,
-
-       PIN_PTA,
-       PIN_RM,
-       PIN_KBCE,
-       PIN_KBCF,
-       PIN_GMA,
-       PIN_GMC,
-       PIN_SDMMC1,
-       PIN_OWC,
+       PINGRP_ATA,
+       PINGRP_ATB,
+       PINGRP_ATC,
+       PINGRP_ATD,
+       PINGRP_CDEV1,
+       PINGRP_CDEV2,
+       PINGRP_CSUS,
+       PINGRP_DAP1,
+
+       PINGRP_DAP2,
+       PINGRP_DAP3,
+       PINGRP_DAP4,
+       PINGRP_DTA,
+       PINGRP_DTB,
+       PINGRP_DTC,
+       PINGRP_DTD,
+       PINGRP_DTE,
+
+       PINGRP_GPU,
+       PINGRP_GPV,
+       PINGRP_I2CP,
+       PINGRP_IRTX,
+       PINGRP_IRRX,
+       PINGRP_KBCB,
+       PINGRP_KBCA,
+       PINGRP_PMC,
+
+       PINGRP_PTA,
+       PINGRP_RM,
+       PINGRP_KBCE,
+       PINGRP_KBCF,
+       PINGRP_GMA,
+       PINGRP_GMC,
+       PINGRP_SDMMC1,
+       PINGRP_OWC,
 
        /* 32: APB_MISC_PP_TRISTATE_REG_B_0 */
-       PIN_GME,
-       PIN_SDC,
-       PIN_SDD,
-       PIN_RESERVED0,
-       PIN_SLXA,
-       PIN_SLXC,
-       PIN_SLXD,
-       PIN_SLXK,
-
-       PIN_SPDI,
-       PIN_SPDO,
-       PIN_SPIA,
-       PIN_SPIB,
-       PIN_SPIC,
-       PIN_SPID,
-       PIN_SPIE,
-       PIN_SPIF,
-
-       PIN_SPIG,
-       PIN_SPIH,
-       PIN_UAA,
-       PIN_UAB,
-       PIN_UAC,
-       PIN_UAD,
-       PIN_UCA,
-       PIN_UCB,
-
-       PIN_RESERVED1,
-       PIN_ATE,
-       PIN_KBCC,
-       PIN_RESERVED2,
-       PIN_RESERVED3,
-       PIN_GMB,
-       PIN_GMD,
-       PIN_DDC,
+       PINGRP_GME,
+       PINGRP_SDC,
+       PINGRP_SDD,
+       PINGRP_RESERVED0,
+       PINGRP_SLXA,
+       PINGRP_SLXC,
+       PINGRP_SLXD,
+       PINGRP_SLXK,
+
+       PINGRP_SPDI,
+       PINGRP_SPDO,
+       PINGRP_SPIA,
+       PINGRP_SPIB,
+       PINGRP_SPIC,
+       PINGRP_SPID,
+       PINGRP_SPIE,
+       PINGRP_SPIF,
+
+       PINGRP_SPIG,
+       PINGRP_SPIH,
+       PINGRP_UAA,
+       PINGRP_UAB,
+       PINGRP_UAC,
+       PINGRP_UAD,
+       PINGRP_UCA,
+       PINGRP_UCB,
+
+       PINGRP_RESERVED1,
+       PINGRP_ATE,
+       PINGRP_KBCC,
+       PINGRP_RESERVED2,
+       PINGRP_RESERVED3,
+       PINGRP_GMB,
+       PINGRP_GMD,
+       PINGRP_DDC,
 
        /* 64: APB_MISC_PP_TRISTATE_REG_C_0 */
-       PIN_LD0,
-       PIN_LD1,
-       PIN_LD2,
-       PIN_LD3,
-       PIN_LD4,
-       PIN_LD5,
-       PIN_LD6,
-       PIN_LD7,
-
-       PIN_LD8,
-       PIN_LD9,
-       PIN_LD10,
-       PIN_LD11,
-       PIN_LD12,
-       PIN_LD13,
-       PIN_LD14,
-       PIN_LD15,
-
-       PIN_LD16,
-       PIN_LD17,
-       PIN_LHP0,
-       PIN_LHP1,
-       PIN_LHP2,
-       PIN_LVP0,
-       PIN_LVP1,
-       PIN_HDINT,
-
-       PIN_LM0,
-       PIN_LM1,
-       PIN_LVS,
-       PIN_LSC0,
-       PIN_LSC1,
-       PIN_LSCK,
-       PIN_LDC,
-       PIN_LCSN,
+       PINGRP_LD0,
+       PINGRP_LD1,
+       PINGRP_LD2,
+       PINGRP_LD3,
+       PINGRP_LD4,
+       PINGRP_LD5,
+       PINGRP_LD6,
+       PINGRP_LD7,
+
+       PINGRP_LD8,
+       PINGRP_LD9,
+       PINGRP_LD10,
+       PINGRP_LD11,
+       PINGRP_LD12,
+       PINGRP_LD13,
+       PINGRP_LD14,
+       PINGRP_LD15,
+
+       PINGRP_LD16,
+       PINGRP_LD17,
+       PINGRP_LHP0,
+       PINGRP_LHP1,
+       PINGRP_LHP2,
+       PINGRP_LVP0,
+       PINGRP_LVP1,
+       PINGRP_HDINT,
+
+       PINGRP_LM0,
+       PINGRP_LM1,
+       PINGRP_LVS,
+       PINGRP_LSC0,
+       PINGRP_LSC1,
+       PINGRP_LSCK,
+       PINGRP_LDC,
+       PINGRP_LCSN,
 
        /* 96: APB_MISC_PP_TRISTATE_REG_D_0 */
-       PIN_LSPI,
-       PIN_LSDA,
-       PIN_LSDI,
-       PIN_LPW0,
-       PIN_LPW1,
-       PIN_LPW2,
-       PIN_LDI,
-       PIN_LHS,
-
-       PIN_LPP,
-       PIN_RESERVED4,
-       PIN_KBCD,
-       PIN_GPU7,
-       PIN_DTF,
-       PIN_UDA,
-       PIN_CRTP,
-       PIN_SDB,
+       PINGRP_LSPI,
+       PINGRP_LSDA,
+       PINGRP_LSDI,
+       PINGRP_LPW0,
+       PINGRP_LPW1,
+       PINGRP_LPW2,
+       PINGRP_LDI,
+       PINGRP_LHS,
+
+       PINGRP_LPP,
+       PINGRP_RESERVED4,
+       PINGRP_KBCD,
+       PINGRP_GPU7,
+       PINGRP_DTF,
+       PINGRP_UDA,
+       PINGRP_CRTP,
+       PINGRP_SDB,
 };
 
 
@@ -172,25 +172,25 @@ struct pmux_tri_ctlr {
 
        uint pmt_reserved[22];          /* ABP_MISC_PP_ reserved offs 28-7C */
 
-       uint pmt_ctl_a;                 /* _PIN_MUX_CTL_A_0, offset 80 */
-       uint pmt_ctl_b;                 /* _PIN_MUX_CTL_B_0, offset 84 */
-       uint pmt_ctl_c;                 /* _PIN_MUX_CTL_C_0, offset 88 */
-       uint pmt_ctl_d;                 /* _PIN_MUX_CTL_D_0, offset 8C */
-       uint pmt_ctl_e;                 /* _PIN_MUX_CTL_E_0, offset 90 */
-       uint pmt_ctl_f;                 /* _PIN_MUX_CTL_F_0, offset 94 */
-       uint pmt_ctl_g;                 /* _PIN_MUX_CTL_G_0, offset 98 */
+       uint pmt_ctl_a;                 /* _PINGRP_MUX_CTL_A_0, offset 80 */
+       uint pmt_ctl_b;                 /* _PINGRP_MUX_CTL_B_0, offset 84 */
+       uint pmt_ctl_c;                 /* _PINGRP_MUX_CTL_C_0, offset 88 */
+       uint pmt_ctl_d;                 /* _PINGRP_MUX_CTL_D_0, offset 8C */
+       uint pmt_ctl_e;                 /* _PINGRP_MUX_CTL_E_0, offset 90 */
+       uint pmt_ctl_f;                 /* _PINGRP_MUX_CTL_F_0, offset 94 */
+       uint pmt_ctl_g;                 /* _PINGRP_MUX_CTL_G_0, offset 98 */
 };
 
-/* Converts a pin number to a tristate register: 0=A, 1=B, 2=C, 3=D */
+/* Converts a pin group to a tristate register: 0=A, 1=B, 2=C, 3=D */
 #define TRISTATE_REG(id) ((id) >> 5)
 
 /* Mask value for a tristate (within TRISTATE_REG(id)) */
 #define TRISTATE_MASK(id) (1 << ((id) & 0x1f))
 
-/* Set a pin to tristate */
-void pinmux_tristate_enable(enum pmux_pin pin);
+/* Set a pin group to tristate */
+void pinmux_tristate_enable(enum pmux_pingrp pin);
 
-/* Set a pin to normal (non tristate) */
-void pinmux_tristate_disable(enum pmux_pin pin);
+/* Set a pin group to normal (non tristate) */
+void pinmux_tristate_disable(enum pmux_pingrp pin);
 
 #endif /* PINMUX_H */
index 9672c5e259e2d21980a515e4e7abc599a8ca5183..35ff2ef03cbf33930d37faa89c01cb76b8427db8 100644 (file)
@@ -94,15 +94,15 @@ static void pin_mux_uart(void)
        reg &= 0xFFF0FFFF;      /* IRRX_/IRTX_SEL [19:16] = 00 UARTA */
        writel(reg, &pmt->pmt_ctl_c);
 
-       pinmux_tristate_disable(PIN_IRRX);
-       pinmux_tristate_disable(PIN_IRTX);
+       pinmux_tristate_disable(PINGRP_IRRX);
+       pinmux_tristate_disable(PINGRP_IRTX);
 #endif /* CONFIG_TEGRA2_ENABLE_UARTA */
 #if defined(CONFIG_TEGRA2_ENABLE_UARTD)
        reg = readl(&pmt->pmt_ctl_b);
        reg &= 0xFFFFFFF3;      /* GMC_SEL [3:2] = 00, UARTD */
        writel(reg, &pmt->pmt_ctl_b);
 
-       pinmux_tristate_disable(PIN_GMC);
+       pinmux_tristate_disable(PINGRP_GMC);
 #endif /* CONFIG_TEGRA2_ENABLE_UARTD */
 }
 
@@ -138,9 +138,9 @@ static void pin_mux_mmc(void)
        reg |= (3 << 0);        /* GME_SEL [1:0] = 11 SDIO4 */
        writel(reg, &pmt->pmt_ctl_d);
 
-       pinmux_tristate_disable(PIN_ATB);
-       pinmux_tristate_disable(PIN_GMA);
-       pinmux_tristate_disable(PIN_GME);
+       pinmux_tristate_disable(PINGRP_ATB);
+       pinmux_tristate_disable(PINGRP_GMA);
+       pinmux_tristate_disable(PINGRP_GME);
 
        /* SDMMC3 */
        /* SDIO3_CLK, SDIO3_CMD, SDIO3_DAT[3:0] */
@@ -151,9 +151,9 @@ static void pin_mux_mmc(void)
        reg |= (2 << 14);       /* SDD_SEL [15:14] = 01 SDIO3 */
        writel(reg, &pmt->pmt_ctl_d);
 
-       pinmux_tristate_disable(PIN_SDC);
-       pinmux_tristate_disable(PIN_SDD);
-       pinmux_tristate_disable(PIN_SDB);
+       pinmux_tristate_disable(PINGRP_SDC);
+       pinmux_tristate_disable(PINGRP_SDD);
+       pinmux_tristate_disable(PINGRP_SDB);
 }
 #endif