some comments

diff --git a/src/include/gnunet_reclaim_attribute_lib.h b/src/include/gnunet_reclaim_attribute_lib.h
index 34429da51045bf9b73146bf3ab3257a5eaeba59c..8476e77fc2ff9c645b993822b4e4bbc68558657a 100644 (file)
--- a/src/include/gnunet_reclaim_attribute_lib.h
+++ b/src/include/gnunet_reclaim_attribute_lib.h
@@ -348,6 +348,12 @@ GNUNET_RECLAIM_ATTRIBUTE_number_to_typename (uint32_t type);
 
 /**
    * Get required size for serialization buffer
+   * FIXME:
+   * 1. The naming convention is violated here.
+   * It should GNUNET_RECLAIM_ATTRIBUTE_<lowercase from here>.
+   * It might make sense to refactor attestations into a separate folder.
+   * 2. The struct should be called GNUNET_RECLAIM_ATTESTATION_Data or
+   * GNUNET_RECLAIM_ATTRIBUTE_Attestation depending on location in source.
    *
    * @param attr the attestation to serialize
    * @return the required buffer size

diff --git a/src/include/gnunet_reclaim_attribute_plugin.h b/src/include/gnunet_reclaim_attribute_plugin.h
index bdd815dcf260f5d9f916d1bf4d7a08659efaff5b..e61cca5b22f420799669e521eea019732e34add2 100644 (file)
--- a/src/include/gnunet_reclaim_attribute_plugin.h
+++ b/src/include/gnunet_reclaim_attribute_plugin.h
@@ -136,8 +136,14 @@ struct GNUNET_RECLAIM_ATTRIBUTE_PluginFunctions
   GNUNET_RECLAIM_ATTRIBUTE_NumberToTypenameFunction number_to_typename;
 
   /**
-* Attestation Conversion to string.
-*/
+   * FIXME: It is odd that attestation functions are withing the attribute
+   * plugin. An attribute type may be backed by an attestation, but not
+   * necessarily.
+   * Maybe it would make more sense to refactor this into an attestation
+   * plugin?
+   *
+   * Attestation Conversion to string.
+   */
   GNUNET_RECLAIM_ATTRIBUTE_ValueToStringFunction value_to_string_attest;
 
   /**