Fix the return value for SSL_get0_chain_certs()
authorMatt Caswell <matt@openssl.org>
Tue, 16 Jul 2019 14:32:35 +0000 (15:32 +0100)
committerMatt Caswell <matt@openssl.org>
Wed, 17 Jul 2019 11:38:46 +0000 (12:38 +0100)
This function was always returning 0. It should return 1 on success.

Fixes #9374

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
(Merged from https://github.com/openssl/openssl/pull/9395)

(cherry picked from commit 7bc82358ae930cfbd353602bc1fd25bfad107350)

ssl/s3_lib.c

index d7dbf99954cfd71b732420cdaf4e22a2dbef33dc..55c0192d2920949a648d5637754078cdac4088bb 100644 (file)
@@ -3567,6 +3567,7 @@ long ssl3_ctrl(SSL *s, int cmd, long larg, void *parg)
 
     case SSL_CTRL_GET_CHAIN_CERTS:
         *(STACK_OF(X509) **)parg = s->cert->key->chain;
+        ret = 1;
         break;
 
     case SSL_CTRL_SELECT_CURRENT_CERT: