Patch from Mike Snitzer <snitzer@gmail.com>:

Please see the attached patch for the following crash with busybox'
2.6 rmmod support

diff --git a/modutils/rmmod.c b/modutils/rmmod.c
index 3693aec7c718d357d1790c15077dcf24ca962981..f4e65d0ce2f965d56721f50ff7cb59681d442c3d 100644 (file)
--- a/modutils/rmmod.c
+++ b/modutils/rmmod.c
@@ -106,13 +106,13 @@ extern int rmmod_main(int argc, char **argv)
                bb_show_usage();
 
        {
+               for (n = optind; n < argc; n++) {
 #ifdef CONFIG_FEATURE_2_6_MODULES
-               char module_name[strlen(argv[n]) + 1];
-               filename2modname(module_name, argv[n]);
+                       char module_name[strlen(argv[n]) + 1];
+                       filename2modname(module_name, argv[n]);
 #else
 #define module_name            argv[n]
 #endif
-               for (n = optind; n < argc; n++) {
                        if (syscall(__NR_delete_module, module_name, flags) < 0) {
                                bb_perror_msg("%s", argv[n]);
                                ret = EXIT_FAILURE;