docu

diff --git a/BUGS b/BUGS
index 9c2b203981bb3737a6a11076f2ca186128298d30..f5dd633a5f16a9d5f2c680c73148a7bc374ab015 100644 (file)
--- a/BUGS
+++ b/BUGS
@@ -100,3 +100,7 @@ sane end-user should care about this codebase yet anyway.
 * TESTING:
   - consider changing API for peer-group termination to 
     call continuation when done
+
+* HOSTLIST:
+  - 'server' uses 'GNUNET_PEERINFO_iterate', should probably switch to notification API
+    (for more instant / up-to-date hostlists at lower cost) [OPTIMIZATION]

diff --git a/TODO b/TODO
index 6f01259c24f37ba1aff4b26a5aedf3e31e13305a..02ba1ee1f96bf2769113503e0e90ab5a0ae1c955 100644 (file)
--- a/TODO
+++ b/TODO
@@ -13,10 +13,28 @@ away), in order in which they will likely be done:
 
 Urgent items (before announcing ng.gnunet.org):
 * topology
-  - HELLO advertising does not work (no solicitation!)
+  - valgrind crash (in topology test case):
+==31107== Invalid read of size 8                                                                                                             
+==31107==    at 0x401DA1: free_peer (gnunet-daemon-topology.c:480)                                                                           
+==31107==    by 0x4030A2: cleaning_task (gnunet-daemon-topology.c:1212)                                                                      
+==31107==    by 0x545DCBD: run_ready (scheduler.c:482)                                                                                       
+==31107==    by 0x545E0CD: GNUNET_SCHEDULER_run (scheduler.c:609)                                                                            
+==31107==    by 0x545B00F: GNUNET_PROGRAM_run (program.c:223)                                                                                
+==31107==    by 0x403477: main (gnunet-daemon-topology.c:1346)                                                                               
+==31107==  Address 0x737e828 is 8 bytes inside a block of size 144 free'd                                                                    
+==31107==    at 0x4C21DBC: free (vg_replace_malloc.c:325)                                                                                    
+==31107==    by 0x544240B: GNUNET_xfree_ (common_allocation.c:144)                                                                           
+==31107==    by 0x401E13: free_peer (gnunet-daemon-topology.c:487)                                                                           
+==31107==    by 0x4030A2: cleaning_task (gnunet-daemon-topology.c:1212)                                                                      
+==31107==    by 0x545DCBD: run_ready (scheduler.c:482)                                                                                       
+==31107==    by 0x545E0CD: GNUNET_SCHEDULER_run (scheduler.c:609)                                                                            
+==31107==    by 0x545B00F: GNUNET_PROGRAM_run (program.c:223)                                                                                
+==31107==    by 0x403477: main (gnunet-daemon-topology.c:1346)                                                                               
+==31107==                                                                                                                                    
   - considers peers 'connected' well before they actually are
-    (since core notifies about it too early?)
-  - needs testing
+    (since core notifies about it too early?);
+  - (forced) disconnect does not work (also CORE API issue)
+  - needs testing (not sure the current testcase does much...)
 * hostlist
   - test fails (looks like it works, but that's because of a bad
     connectivity notification; somehow core is unable to send

diff --git a/src/core/Makefile.am b/src/core/Makefile.am
index 3dccb2dbd9f490d5e1488a2cb73ae8445f3df3d0..605b8d2ce535304c520e5594782756d81a15f7db 100644 (file)
--- a/src/core/Makefile.am
+++ b/src/core/Makefile.am
@@ -15,7 +15,8 @@ lib_LTLIBRARIES = \
 
 libgnunetcore_la_SOURCES = \
   core_api.c core.h \
-  core_api_peer_get_info.c
+  core_api_peer_get_info.c \
+  core_api_peer_request.c
 libgnunetcore_la_LIBADD = \
   $(top_builddir)/src/arm/libgnunetarm.la \
   $(top_builddir)/src/util/libgnunetutil.la \

diff --git a/src/fs/gnunet-directory.c b/src/fs/gnunet-directory.c
index fe2ae8af66508b573f6ced3a73f729d7554ebd40..de4ccdd3fbd7eb24e60ab169e901eeb8d8e57f74 100644 (file)
--- a/src/fs/gnunet-directory.c
+++ b/src/fs/gnunet-directory.c
@@ -31,6 +31,7 @@ static int ret;
  * Print a meta data entry.
  *
  * @param cls closure (unused)
+ * @param plugin_name name of the plugin that generated the meta data
  * @param type type of the keyword
  * @param format format of data
  * @param data_mime_type mime type of data

diff --git a/src/fs/gnunet-publish.c b/src/fs/gnunet-publish.c
index 226877b153accd019d87eaa76732a098099d7f5c..d063b73c7473d76adf68a7d5a28919f7cc808458 100644 (file)
--- a/src/fs/gnunet-publish.c
+++ b/src/fs/gnunet-publish.c
@@ -138,6 +138,7 @@ progress_cb (void *cls,
  * metadata and the filename).
  *
  * @param cls closure
+ * @param plugin_name name of the plugin that generated the meta data
  * @param type type of the meta data
  * @param format format of data
  * @param data_mime_type mime type of data
@@ -171,6 +172,7 @@ meta_printer (void *cls,
  * Merge metadata entries.
  *
  * @param cls closure, target metadata structure
+ * @param plugin_name name of the plugin that generated the meta data
  * @param type type of the meta data
  * @param format format of data
  * @param data_mime_type mime type of data

diff --git a/src/include/gnunet_core_service.h b/src/include/gnunet_core_service.h
index 3ee2f102f1ce36c4dccd5f50a14cacbacd9015e8..afe762772d5022a63970e595c666601b23b5300d 100644 (file)
--- a/src/include/gnunet_core_service.h
+++ b/src/include/gnunet_core_service.h
@@ -1,6 +1,6 @@
 /*
      This file is part of GNUnet.
-     (C) 2009 Christian Grothoff (and other contributing authors)
+     (C) 2009, 2010 Christian Grothoff (and other contributing authors)
 
      GNUnet is free software; you can redistribute it and/or modify
      it under the terms of the GNU General Public License as published
@@ -175,6 +175,27 @@ GNUNET_CORE_connect (struct GNUNET_SCHEDULER_Handle *sched,
 void GNUNET_CORE_disconnect (struct GNUNET_CORE_Handle *handle);
 
 
+struct GNUNET_CORE_PeerRequestHandle;
+
+struct GNUNET_CORE_PeerRequestHandle *
+struct GNUNET_CORE_peer_request_connect (struct GNUNET_SCHEDULER_Handle *sched,
+                                        const struct GNUNET_CONFIGURATION_Handle *cfg,
+                                        const struct GNUNET_PeerIdentity * peer,
+                                        GNUNET_SCHEDULER_Task cont,
+                                        void *cont_cls);
+
+
+struct GNUNET_CORE_PeerRequestHandle *
+struct GNUNET_CORE_peer_request_disconnect (struct GNUNET_SCHEDULER_Handle *sched,
+                                           const struct GNUNET_CONFIGURATION_Handle *cfg,
+                                           const struct GNUNET_PeerIdentity * peer,
+                                           GNUNET_SCHEDULER_Task cont,
+                                           void *cont_cls);
+
+void
+GNUNET_CORE_peer_request_cancel (struct GNUNET_CORE_PeerRequestHandle *req);
+
+
 /**
  * Function called with statistics about the given peer.
  *

diff --git a/src/include/gnunet_transport_service.h b/src/include/gnunet_transport_service.h
index a705d3e10e498941b4d6f0706259dbbe7f494a86..726e03a9517efb14ab36d8347b4e1e64c2e47a14 100644 (file)
--- a/src/include/gnunet_transport_service.h
+++ b/src/include/gnunet_transport_service.h
@@ -238,7 +238,7 @@ GNUNET_TRANSPORT_offer_hello (struct GNUNET_TRANSPORT_Handle *handle,
  * Convert a binary address into a human
  * readable address.
  *
- * @param handle connection to transport service
+ * @param sched scheduler to use
  * @param cfg configuration to use
  * @param address address to convert (binary format)
  * @param addressLen number of bytes in address

diff --git a/src/topology/gnunet-daemon-topology.c b/src/topology/gnunet-daemon-topology.c
index 5c581fd42cfdbb31a40c740b977ff97811b073f2..0e4bbffc90840a02468b8c36db01e391a2107ea1 100644 (file)
--- a/src/topology/gnunet-daemon-topology.c
+++ b/src/topology/gnunet-daemon-topology.c
@@ -347,8 +347,7 @@ ready_callback (void *cls,
 /**
  * Try to connect to the specified peer.
  *
- * @param peer who we should try to connect to
- * @param pos entry in our friend list; NULL if not in friend list yet
+ * @param pos peer to connect to
  */
 static void
 attempt_connect (struct PeerList *pos)

diff --git a/src/transport/gnunet-service-transport.c b/src/transport/gnunet-service-transport.c
index 8196dd45a4ad9121231db4b3093d299222bfdb1b..6b8e0e7dd0e30a0339b112cc3c7aea289c9be025 100644 (file)
--- a/src/transport/gnunet-service-transport.c
+++ b/src/transport/gnunet-service-transport.c
@@ -840,9 +840,6 @@ try_transmission_to_peer (struct NeighbourList *neighbour);
  * @param cls closure, identifies the entry on the
  *            message queue that was transmitted and the
  *            client responsible for queueing the message
- * @param rl identifies plugin used for the transmission for
- *           this neighbour; needs to be re-enabled for
- *           future transmissions
  * @param target the peer receiving the message
  * @param result GNUNET_OK on success, if the transmission
  *           failed, we should not tell the client to transmit

diff --git a/src/util/pseudonym.c b/src/util/pseudonym.c
index 07c05b9e67bb8e56cecdf9a3aa1b2a4879d8f55e..dfacbdcd81067eaabb08d96c4132b1f5b475019c 100644 (file)
--- a/src/util/pseudonym.c
+++ b/src/util/pseudonym.c
@@ -540,11 +540,12 @@ GNUNET_PSEUDONYM_rank (const struct GNUNET_CONFIGURATION_Handle *cfg,
  * Insert metadata into existing MD record (passed as cls).
  *
  * @param cls metadata to add to
+ * @param plugin_name name of the plugin that generated the meta data
  * @param type type of entry to insert
  * @param format format of data
  * @param data_mime_type mime type of data
  * @param data value of the meta data
- * @param data_size number of bytes in data
+ * @param data_len number of bytes in data
  * @return always 0
  */
 static int